-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continous Benchmark #1392
base: dev
Are you sure you want to change the base?
Continous Benchmark #1392
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1392 +/- ##
==========================================
- Coverage 82.94% 82.93% -0.02%
==========================================
Files 273 273
Lines 46353 46353
Branches 9642 9472 -170
==========================================
- Hits 38446 38441 -5
- Misses 7280 7311 +31
+ Partials 627 601 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Where can I see the benchmark result? |
@tigercosmos Check "Run benchmark" step https://github.com/seladb/PcapPlusPlus/actions/runs/10644856460/job/29510043289 Approx. 10Gbps parsing, 1Gbps crafting performance in GitHub CI (just looking bytes per sec). Also items per sec is a good indicator which can we tabulate as for mean packet sizes (For example, if avg packet length 64, 512, 1024, 1500 etc -> size* items per sec *8 |
Will it show a warning if the benchmark performance decreases too much? Otherwise, people will not click into the CI and check the result. |
@tigercosmos Actually my aim is to generate and update the benchmark results automatically. I enabled PR runs for just testing. I'll disable it when the work is done, and the runs will be only from master or dev. Because benchmark results can be very flaky without a dedicated machine/runner unfortunately. This workflow and integration with Google benchmark are just for easier benchmarking in local PCs and to give an idea about to performance in PcapPlusPlus website (since current benchmark really old) |
Automatically generate performance benchmark information for website using Google Benchmark