Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply clang-format to Tests #1456

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Jun 21, 2024

part of #1248

@tigercosmos tigercosmos requested a review from seladb as a code owner June 21, 2024 07:36
@tigercosmos tigercosmos changed the base branch from master to dev June 21, 2024 07:36
@tigercosmos tigercosmos force-pushed the clang-format0621 branch 2 times, most recently from 61c6d59 to fafe143 Compare June 21, 2024 07:41
@tigercosmos
Copy link
Collaborator Author

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.

TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21

@egecetin egecetin added this to the Augest 2024 Release milestone Jun 21, 2024
@seladb
Copy link
Owner

seladb commented Jun 25, 2024

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.

TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21

Does it work for you locally?

@tigercosmos
Copy link
Collaborator Author

It's weird. I checked the modification of LoggerTests.cpp, and it should not cause any error.

TestLogger                         : FAILED (D:\a\PcapPlusPlus\PcapPlusPlus\Tests\Pcap++Test\Tests\LoggerTests.cpp:213). Assert EQUAL failed:
   Actual:   20
   Expected: 21

Does it work for you locally?

No, it doesn't. It's weird, as the code shouldn't make any difference of the logic.


// clang-format off
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know why, but seems the formatting of this part will break the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants