Run clang-format for Examples and Tutorials
#1464
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1464 +/- ##
=======================================
Coverage 82.67% 82.68%
=======================================
Files 171 171
Lines 22623 22623
Branches 8570 8570
=======================================
+ Hits 18704 18705 +1
+ Misses 3103 3093 -10
- Partials 816 825 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Examples/ArpSpoofing/main.cpp
Outdated
| { "interface", required_argument, nullptr, 'i' }, | ||
| { "victim", required_argument, nullptr, 'c' }, | ||
| { "gateway", required_argument, nullptr, 'g' }, | ||
| { "help", no_argument, nullptr, 'h' }, | ||
| { "version", no_argument, nullptr, 'v' }, | ||
| { nullptr, 0, nullptr, 0 } |
There was a problem hiding this comment.
@tigercosmos for some reason clang-format mixes tabs and spaces here, I have no idea why 🤷♂️
I tried different things but couldn't make it to work. Maybe you know?
It happens in other files also, like here:
But in others it doesn't happen:
There was a problem hiding this comment.
Apparently in some of the files, changing the order of the arguments fixes the issue, this is very weird 😕
There was a problem hiding this comment.
@seladb whenever you think clang-format is stupid, you can turn off the format for that part.
There was a problem hiding this comment.
It's concerning that we can't rely on clang-format and need to go over the code ourselves. This kind of beats the purpose of a code formatter 😕
There was a problem hiding this comment.
@seladb this kind of stuff rarely happens. We are formatting a bunch of code at once so there might be a few weird formatting. But overall, we will get the fruits after all formatting. :)
.clang-format
Outdated
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| BasedOnStyle: Microsoft | |||
| UseTab: AlignWithSpaces | |||
| UseTab: ForIndentation | |||
There was a problem hiding this comment.
@tigercosmos I think we should change this, it looks nicer, what do you think?
If you agree I can open a PR for Common++ as well
There was a problem hiding this comment.
I don't have a strong opinion about it. it's fine to me.
There was a problem hiding this comment.
ok, I'll open a separate PR for this change
|
@seladb precommit failed. did you check if your clang-format version correct? |
Hmm I'm using version 18.1.6 on Windows D:\seladb\PcapPlusPlus\Examples>D:\Apps\LLVM\bin\clang.exe --version
clang version 18.1.6
Target: x86_64-pc-windows-msvc
Thread model: posix |
|
@seladb remember to update |
Yes, that's a good point, thanks for the reminder! |
No description provided.