Skip to content

Conversation

@Dimi1010
Copy link
Collaborator

Part of #1838

This PR updates the synchronous capture method.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 69.09091% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (24cc309) to head (dc91d05).

Files with missing lines Patch % Lines
Pcap++/src/PcapLiveDevice.cpp 69.09% 11 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2026      +/-   ##
==========================================
- Coverage   83.87%   83.45%   -0.43%     
==========================================
  Files         307      311       +4     
  Lines       53952    54584     +632     
  Branches    11352    11560     +208     
==========================================
+ Hits        45254    45551     +297     
- Misses       7483     7815     +332     
- Partials     1215     1218       +3     
Flag Coverage Δ
alpine320 75.86% <50.00%> (-0.03%) ⬇️
fedora42 75.43% <50.00%> (-0.03%) ⬇️
macos-14 81.57% <62.22%> (-0.01%) ⬇️
macos-15 81.56% <62.22%> (-0.02%) ⬇️
mingw32 69.92% <40.62%> (-0.08%) ⬇️
mingw64 69.94% <50.00%> (+0.07%) ⬆️
npcap ?
rhel94 75.43% <51.42%> (-0.05%) ⬇️
ubuntu2004 59.47% <51.42%> (-0.01%) ⬇️
ubuntu2004-zstd 59.58% <51.42%> (+0.01%) ⬆️
ubuntu2204 75.37% <51.42%> (-0.03%) ⬇️
ubuntu2204-icpx 57.85% <55.55%> (+<0.01%) ⬆️
ubuntu2404 75.49% <51.42%> (+<0.01%) ⬆️
ubuntu2404-arm64 75.53% <50.00%> (-0.01%) ⬇️
unittest 83.45% <69.09%> (-0.43%) ⬇️
windows-2022 85.37% <66.66%> (+0.12%) ⬆️
windows-2025 85.40% <68.29%> (+0.07%) ⬆️
winpcap 85.40% <68.29%> (-0.12%) ⬇️
xdp 52.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review November 19, 2025 23:57
@Dimi1010 Dimi1010 requested a review from seladb as a code owner November 19, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant