Pioneer-related features #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roger-Wu
commented
Sep 2, 2018
contract/contracts/Crowdsale.sol
Outdated
| uint public totalStages = 10; | ||
|
|
||
| /// @notice After this moment, users are not becoming pioneers anymore. | ||
| uint public pioneerTimeEnd; // 2018/9/17 24:00 (UTC+8) |
There was a problem hiding this comment.
忘記在 constructor 裡 initialize
tina1998612
reviewed
Sep 2, 2018
contract/contracts/Crowdsale.sol
Outdated
|
|
||
| uint priceInWei; // how many weis for one token |
There was a problem hiding this comment.
為什麼有些是uint有些是uint256? 因為uint=uint256 你這裡應該是想用uint8? range是0-255
There was a problem hiding this comment.
我習慣寫 uint ，飛虎他們有人習慣寫 uint256 所以還沒整合好而已
看要全部改成哪一種
There was a problem hiding this comment.
我偏好explicitly寫成uint256 對別人來說也避免誤會
Roger-Wu
commented
Sep 2, 2018
contract/contracts/Crowdsale.sol
Outdated
| uint _tokensPurchased = _weiPaid.mul(rate); | ||
|
|
||
| // Check if buying enough tokens | ||
| require(_tokensPurchased >= minTokensPurchased, "Purchasing not enough amount of tokens."); |
There was a problem hiding this comment.
應改成
require(tokensPurchased[msg.sender].add(_tokensPurchased) >= minTokensPurchased, "Purchasing not enough amount of tokens.");
如此可以買 200 token 然後買 1 tokens
…nd related variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE