Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message acknowledgements #183

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add message acknowledgements #183

wants to merge 3 commits into from

Conversation

ltuch
Copy link
Contributor

@ltuch ltuch commented Mar 20, 2024 •
edited
Loading

This implements one of the features required for delivery guarantees.

There are 2 policies currently supported:

  • at most once message delivery - the client sends without waiting for message acknowledgements
  • at least once message delivery - the client waits for message acknowledgements. Retries and timeouts can be configured for this policy.

I wanted to tidy up a few things and improve the testability but ran out of time :(

@ltuch ltuch requested a review from petehayes102 March 24, 2024 23:18
@petehayes102 petehayes102 removed their request for review May 30, 2024 00:01
@petehayes102 petehayes102 marked this pull request as draft May 30, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ltuch