Fix the return of odd-numbered pixels for the x264 encoder (#132)

* Fix the return of odd-numbered pixels for the x264 encoder The point of subtracting a dimension%2 from its actual dimension is to avoid odd-numbered pixels, so due to variation of DPR from device to device the subtraction should be done at the end of the pixel calculation. * Make the variables slightly less universal --------- Co-authored-by: Seungmin Kim <[email protected]>
selkies-project · Dec 29, 2023 · 7659218 · 7659218
1 parent 2498ecc
commit 7659218
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/addons/gst-web/src/input.js b/addons/gst-web/src/input.js
@@ -535,8 +535,8 @@ class Input {
 
     getWindowResolution() {
         return [
-            parseInt((document.body.offsetWidth - document.body.offsetWidth%2) * window.devicePixelRatio),
-            parseInt((document.body.offsetHeight - document.body.offsetHeight%2) * window.devicePixelRatio)
+            parseInt( (() => {var offsetRatioWidth = document.body.offsetWidth * window.devicePixelRatio; return offsetRatioWidth - offsetRatioWidth % 2})() ),
+            parseInt( (() => {var offsetRatioHeight = document.body.offsetHeight * window.devicePixelRatio; return offsetRatioHeight - offsetRatioHeight % 2})() )
         ];
     }
 }
@@ -562,4 +562,4 @@ function addListener(obj, name, func, ctx) {
 function removeListeners(listeners) {
     for (const listener of listeners)
         listener[0].removeEventListener(listener[1], listener[2]);
-}
+}