vah264enc (in progress)

selkies-project · Feb 22, 2024 · ffb285d · ffb285d
1 parent 7c278ee
commit ffb285d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/selkies_gstreamer/gstwebrtc_app.py b/src/selkies_gstreamer/gstwebrtc_app.py
@@ -312,7 +312,8 @@ def build_video_pipeline(self):
             # color converter
             vapostproc = Gst.ElementFactory.make("vapostproc")
             vapostproc.set_property("scale-method", "fast")
-            vapostproc_caps = Gst.caps_from_string("video/x-raw(memory:VAMemory)")
+            # TODO: Investigate the usage of 'GstVaDisplay' and 'video/x-raw(memory:VAMemory)' like how 'video/x-raw(memory:CUDAMemory)' is used with NVIDIA
+            vapostproc_caps = Gst.caps_from_string("video/x-raw")
             vapostproc_caps.set_value("format", "NV12")
             vapostproc_capsfilter = Gst.ElementFactory.make("capsfilter")
             vapostproc_capsfilter.set_property("caps", vapostproc_caps)
@@ -450,7 +451,7 @@ def build_video_pipeline(self):
             self.pipeline.add(rtph264pay)
             self.pipeline.add(rtph264pay_capsfilter)
 
-        elif self.encoder == "vah264enc":
+        elif self.encoder in ["vah264enc", "vah264lpenc"]:
             self.pipeline.add(vapostproc)
             self.pipeline.add(vapostproc_capsfilter)
             self.pipeline.add(vah264enc)
@@ -513,7 +514,7 @@ def build_video_pipeline(self):
                 raise GSTWebRTCAppError(
                     "Failed to link rtph264pay_capsfilter -> webrtcbin")
 
-        elif self.encoder == "vah264enc":
+        elif self.encoder in ["vah264enc", "vah264lpenc"]:
             if not Gst.Element.link(self.ximagesrc_capsfilter, vapostproc):
                 raise GSTWebRTCAppError(
                     "Failed to link ximagesrc_capsfilter -> vapostproc")
@@ -727,7 +728,7 @@ def check_plugins(self):
         required = ["opus", "nice", "webrtc", "dtls", "srtp", "rtp", "sctp",
                     "rtpmanager", "ximagesrc"]
 
-        supported = ["nvh264enc", "vah264enc", "x264enc", "vp8enc", "vp9enc"]
+        supported = ["nvh264enc", "vah264enc", "vah264lpenc", "x264enc", "vp8enc", "vp9enc"]
         if self.encoder not in supported:
             raise GSTWebRTCAppError('Unsupported encoder, must be one of: ' + ','.join(supported))