-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added debian 12 dockerfiles and deb packages #163
base: main
Are you sure you want to change the base?
Conversation
Is there any difference in the code(s) and apt-get installations aside from the base container being Debian? If there isn't, there's an option to just change the base container ARG, which will reduce the volume of code added. This is to reduce the code footprint maintainers are required to manage, and because the containers are one of the most frequently changed code in the repository. |
For instance, it would be possible to use:
And these values can be changed with the GitHub Actions configuration files. |
How does the Ubuntu 24.04 KDE container feel like in your infrastructure after the update yesterday I made? |
QBO https://qbo.io/#/ uses kind base images based on and not supervisord. They are based on debian 12 and I had to compile/create debian packages so I ca replicate this: Also It would be nice to have a local option instead of just depending on github actions when building the images as I added in my PR Please let me know if you are interested to see the systemd version. |
I could take a look, but systemd is prohibitive in many K8s environments which don't accept disabling seccomp or apparmor. |
I will implement this without having additional Dockerfiles in time for v1.6.2 once our Conda build pipeline succeeds from an upstream issue. |
That would be awesome thank you. You can use my PR to see the difference between Ubuntu and Debian. I can help with testing. . |
I've run out of time to do this... To Maintainers or @alexeadem: Do not merge this as-is. The same Dockerfile and sh scripts must build the Ubuntu and Debian packages together. Use Example: Change for example Then, update the GitHub Actions files to add Debian containers in the build (preferably also including the example container). Ubuntu and Debian MUST be built with the same Dockerfile to reduce future maintenance load. Plus, a bunch of package dependencies have been taken out from the Dockerfiles for v1.6.2, so a lot of the dependencies from v1.6.1 are now unnecessary. |
493e90f moves initially towards my intentions. The remaining phase would be to clean up the documentation to include Debian, clean up Ubuntu-specific PPAs, and enable the builds in GitHub Actions. |
Reference the issue numbers and reviewers
Explain relevant issues and how this pull request solves them
Describe the changes in code and its dependencies and justify that they work as intended after testing
Describe alternatives you've considered
Additional context