-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows for building+publishing images & creating releases #23
Conversation
I'm not sure how to test these, as the Actions console only supports running workflows that are already on the default branch. |
513e7c2
to
d7d3515
Compare
We could simply merge this PR and debug from there 🤷🏻 |
After cursory research, it sounds like the prevailing wisdom is to optimistically merge all manually-triggered workflows, then later debug their behavior semi-manually while writing a second PR for the triggers. |
This PR is now safe to merge - after merging, I can test the new workflows and PR the on-push triggers for the image workflows. |
|
cbbef74
to
79e9c08
Compare
15bacf9
to
6be3166
Compare
1641a3a
to
23d3367
Compare
23d3367
to
df30a74
Compare
df30a74
to
55408d2
Compare
@danisla I implemented those changes. |
* update xpra-html5 to get fix to auto-hide feature * Add workflows for building+publishing images & creating releases (#23) * Copy workflows & action from gstreamer See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github * Add newlines for formatting * Add name * Add description * Alphabetize inputs * Add input descriptions * Rename & simplify release creator * Replace gstreamer logic with vdi template logic * Reuse "all images" workflow for automation changes * Generalize "changed images" workflow for future reuse * Add WebRTC image build/publish automation * Remove automation templates * Default to use caching * Add build/publish automation for images that are simple in cloudbuild * Add app-streaming images build/publish automation * Add app-proxy image build/publish automation * Remove automatic triggers for untested image workflows * Overwrite remaining stubs * Simplify image names * Fix alphabetization mistake * Improve app-streaming image versioning * Fix copy/paste typos * Improve on-manual trigger descriptions * Simplify triggers & authentication * Simplify image builder job names * Clone Xpra submodule when building xpra image * Mark releases as drafts, for manual completion Co-authored-by: Jan Van Bruggen <[email protected]>
* update xpra-html5 to get fix to auto-hide feature * Add workflows for building+publishing images & creating releases (#23) * Copy workflows & action from gstreamer See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github * Add newlines for formatting * Add name * Add description * Alphabetize inputs * Add input descriptions * Rename & simplify release creator * Replace gstreamer logic with vdi template logic * Reuse "all images" workflow for automation changes * Generalize "changed images" workflow for future reuse * Add WebRTC image build/publish automation * Remove automation templates * Default to use caching * Add build/publish automation for images that are simple in cloudbuild * Add app-streaming images build/publish automation * Add app-proxy image build/publish automation * Remove automatic triggers for untested image workflows * Overwrite remaining stubs * Simplify image names * Fix alphabetization mistake * Improve app-streaming image versioning * Fix copy/paste typos * Improve on-manual trigger descriptions * Simplify triggers & authentication * Simplify image builder job names * Clone Xpra submodule when building xpra image * Mark releases as drafts, for manual completion Co-authored-by: Jan Van Bruggen <[email protected]>
* Copy workflows & action from gstreamer See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github * Add newlines for formatting * Add name * Add description * Alphabetize inputs * Add input descriptions * Rename & simplify release creator * Replace gstreamer logic with vdi template logic * Reuse "all images" workflow for automation changes * Generalize "changed images" workflow for future reuse * Add WebRTC image build/publish automation * Remove automation templates * Default to use caching * Add build/publish automation for images that are simple in cloudbuild * Add app-streaming images build/publish automation * Add app-proxy image build/publish automation * Remove automatic triggers for untested image workflows * Overwrite remaining stubs * Simplify image names * Fix alphabetization mistake * Improve app-streaming image versioning * Fix copy/paste typos * Improve on-manual trigger descriptions * Simplify triggers & authentication * Simplify image builder job names * Clone Xpra submodule when building xpra image * Mark releases as drafts, for manual completion
This completes most of #17. #24 will complete the last bit.