Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows for building+publishing images & creating releases #23

Merged
merged 27 commits into from
Jan 27, 2022

Conversation

JanCVanB
Copy link
Member

@JanCVanB JanCVanB commented Jan 25, 2022

This completes most of #17. #24 will complete the last bit.

@JanCVanB
Copy link
Member Author

I'm not sure how to test these, as the Actions console only supports running workflows that are already on the default branch.

@JanCVanB
Copy link
Member Author

We could simply merge this PR and debug from there 🤷🏻

@JanCVanB
Copy link
Member Author

After cursory research, it sounds like the prevailing wisdom is to optimistically merge all manually-triggered workflows, then later debug their behavior semi-manually while writing a second PR for the triggers.

@JanCVanB
Copy link
Member Author

This PR is now safe to merge - after merging, I can test the new workflows and PR the on-push triggers for the image workflows.

@JanCVanB
Copy link
Member Author

JanCVanB commented Jan 25, 2022

Typos! Replace itopia-inc with selkies-project, and replace main with master. Done.

@JanCVanB JanCVanB marked this pull request as draft January 25, 2022 22:43
@JanCVanB JanCVanB changed the base branch from master to dev January 26, 2022 02:35
@JanCVanB JanCVanB force-pushed the add_workflows branch 12 times, most recently from 15bacf9 to 6be3166 Compare January 26, 2022 18:50
@JanCVanB JanCVanB force-pushed the add_workflows branch 2 times, most recently from 1641a3a to 23d3367 Compare January 26, 2022 22:32
.github/workflows/on_release_tag.yaml Outdated Show resolved Hide resolved
.github/workflows/build_and_publish_changed_images.yaml Outdated Show resolved Hide resolved
@JanCVanB
Copy link
Member Author

@danisla I implemented those changes.

@danisla danisla merged commit 61a4a6e into dev Jan 27, 2022
@danisla danisla deleted the add_workflows branch January 27, 2022 01:24
JanCVanB added a commit that referenced this pull request Jan 27, 2022
* update xpra-html5 to get fix to auto-hide feature

* Add workflows for building+publishing images & creating releases (#23)

* Copy workflows & action from gstreamer

See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github

* Add newlines for formatting

* Add name

* Add description

* Alphabetize inputs

* Add input descriptions

* Rename & simplify release creator

* Replace gstreamer logic with vdi template logic

* Reuse "all images" workflow for automation changes

* Generalize "changed images" workflow for future reuse

* Add WebRTC image build/publish automation

* Remove automation templates

* Default to use caching

* Add build/publish automation for images that are simple in cloudbuild

* Add app-streaming images build/publish automation

* Add app-proxy image build/publish automation

* Remove automatic triggers for untested image workflows

* Overwrite remaining stubs

* Simplify image names

* Fix alphabetization mistake

* Improve app-streaming image versioning

* Fix copy/paste typos

* Improve on-manual trigger descriptions

* Simplify triggers & authentication

* Simplify image builder job names

* Clone Xpra submodule when building xpra image

* Mark releases as drafts, for manual completion

Co-authored-by: Jan Van Bruggen <[email protected]>
JanCVanB added a commit that referenced this pull request Jan 27, 2022
* update xpra-html5 to get fix to auto-hide feature

* Add workflows for building+publishing images & creating releases (#23)

* Copy workflows & action from gstreamer

See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github

* Add newlines for formatting

* Add name

* Add description

* Alphabetize inputs

* Add input descriptions

* Rename & simplify release creator

* Replace gstreamer logic with vdi template logic

* Reuse "all images" workflow for automation changes

* Generalize "changed images" workflow for future reuse

* Add WebRTC image build/publish automation

* Remove automation templates

* Default to use caching

* Add build/publish automation for images that are simple in cloudbuild

* Add app-streaming images build/publish automation

* Add app-proxy image build/publish automation

* Remove automatic triggers for untested image workflows

* Overwrite remaining stubs

* Simplify image names

* Fix alphabetization mistake

* Improve app-streaming image versioning

* Fix copy/paste typos

* Improve on-manual trigger descriptions

* Simplify triggers & authentication

* Simplify image builder job names

* Clone Xpra submodule when building xpra image

* Mark releases as drafts, for manual completion

Co-authored-by: Jan Van Bruggen <[email protected]>
JanCVanB added a commit that referenced this pull request Jan 27, 2022
* Copy workflows & action from gstreamer

See https://github.com/selkies-project/selkies-gstreamer/tree/6faebf0942b5dbfb10c6cf51266ebbe83b359ac9/.github

* Add newlines for formatting

* Add name

* Add description

* Alphabetize inputs

* Add input descriptions

* Rename & simplify release creator

* Replace gstreamer logic with vdi template logic

* Reuse "all images" workflow for automation changes

* Generalize "changed images" workflow for future reuse

* Add WebRTC image build/publish automation

* Remove automation templates

* Default to use caching

* Add build/publish automation for images that are simple in cloudbuild

* Add app-streaming images build/publish automation

* Add app-proxy image build/publish automation

* Remove automatic triggers for untested image workflows

* Overwrite remaining stubs

* Simplify image names

* Fix alphabetization mistake

* Improve app-streaming image versioning

* Fix copy/paste typos

* Improve on-manual trigger descriptions

* Simplify triggers & authentication

* Simplify image builder job names

* Clone Xpra submodule when building xpra image

* Mark releases as drafts, for manual completion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants