fix(success): check failCommentCondition before closing issues #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just saw there's already a PR open for this exact thing. Closing in favor of #1026 |
Thank you @sebastian-steiner ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
I noticed the deprecation warning that
failComment=falseshouldn't be used anymore. However, usingfailCommentCondition=falseisn't checked before closing issues.This leads to unexpected error logs and pipeline runs that show up as failed.
I tried to follow the contribution guidelines of semantic-release/semantic-release. If you expect a different format of contributions please let me know.