Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Published Rules - frozen_solid.aws-opensearchserverless-is-public #3133

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

semgrep-dev-pr-bot[bot]
Copy link
Contributor

Wahoo! New published rules with frozen_solid.aws-opensearchserverless-is-public from @frozenSolid.

See semgrep.dev/s/kN7K for more details.

Thanks for your contribution! ❤️

Comment on lines +29 to +31
message: The opensearch serverless collection is accessible from the public internet
using a public VPC endpoint. To fix this, set your `AllowFromPublic` to `"false"`
and specify an internal VPC endpoint in `SourceVPCEs` .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message: The opensearch serverless collection is accessible from the public internet
using a public VPC endpoint. To fix this, set your `AllowFromPublic` to `"false"`
and specify an internal VPC endpoint in `SourceVPCEs` .
message: >-
The opensearch serverless collection is accessible from the public internet
using a public VPC endpoint. To fix this, set your `AllowFromPublic` to `"false"`
and specify an internal VPC endpoint in `SourceVPCEs`.

The rule lints still seem unhappy with your message.

Copy link
Contributor

@0xDC0DE 0xDC0DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please fix the rule lints before we can merge your PR.

@0xDC0DE
Copy link
Contributor

0xDC0DE commented Oct 17, 2023

Before merging, we will also need to move the file to the right directory in the dir structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants