Remove scripts/run-test to simplify, call just osemgrep test #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been almost a month that we run both osemgrep test and pysemgrep --test and no complaints, so let's remove the use of pysemgrep --test so we can then remove the corresponding python code in pysemgrep. test plan: make validate make test-only wait for green CI checks
|
Can I get approval on this one? It's blocking https://github.com/semgrep/semgrep-rules-proprietary/pull/674 which will allow us to finally prevent tests that do not pass CoreScan/ProScan/DeepScan to be merged in. |
0xDC0DE
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been almost a month that we run both osemgrep test
and pysemgrep --test and no complaints, so let's remove
the use of pysemgrep --test so we can then remove the
corresponding python code in pysemgrep.
test plan:
make validate
make test-only
wait for green CI checks