-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more PT-BR translations and fix existing translations #430
Conversation
@LucasHT22 Could you review this when you have time? Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great translation @jlucfarias ! I left some comments, if you disagree with anything, please, let me know.
lang/pt-BR/spec/v1.0.0-beta.md
Outdated
uma versão menor foi incrementado, a versão de correção DEVE ser reinicializada | ||
como 0 (zero). Por exemplo: 1.1.3 -> 2.0.0 e 2.1.7 -> 2.2.0. | ||
|
||
1. A pre-release version number MAY be denoted by appending an arbitrary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here below it is not translated, since you translated the beginning, I suggest translating the rest too:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ sorry for that
lang/pt-BR/spec/v1.0.0.md
Outdated
- [Silas Ribas Martins](https://github.com/silasrm) | ||
- [Rogerio Prado de Jesus](https://github.com/rogeriopradoj) | ||
- [João Lucas Farias](https://github.com/jlucfarias) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason to have translation specifications/translators names here, it already exists in https://semver.org/lang/pt-BR/#sobre , would make it confusing when adding new names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applies to other files too
@jlucfarias Could you check the above review comments? Thanks! |
Suggestions applied now, sorry for the late response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for contributing and reviewing!
PR Checklist
spec
dir.npm run lint
.TRANSLATORS.md
.This PR supercede #384 and fixes #425