-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused css files #447
base: gh-pages
Are you sure you want to change the base?
Conversation
It looks like semver#7 introduces a single-file `main.css`, and makes the other css files unnecessary. This commit also deletes these file to reduce confusion (and repo size).
Also, I'm unsure about the files in ./css/lang/. The layout template includes this: semver.org/_layouts/default.html Lines 6 to 8 in 7b7a979
But that would not resolve to any of the right paths to include the css files, which should then be: - <link rel="stylesheet" href="/css/{{ page.language }}.css">
+ <link rel="stylesheet" href="/css/lang/{{ page.language }}.css"> If you want, I can delete the lang css folder to (or fix the css link in the layout). |
Some lines in |
And while we're talking about minimizing data transfer, perhaps many spaces and new lines can also be removed from the css, in other words: perhaps a minimized version is a good idea to add. |
The files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Great suggestions, thanks!
You can merge all commits, or cherry-pick the ones you would like to see merged. |
If only i had write access 😬 |
I see. Well, let's hope one of the maintainers can merge this. Hopefully, because the site could use some updates. |
It looks like #7 introduces a single-file
main.css
, and makes the other css files unnecessary. This commit also deletes these file to reduce confusion (and repo size).PR Checklist
spec
dir.npm run lint
.(Optional) If you're willing to help reviews about your language's translations, add your name to theTRANSLATORS.md
.