Fix base URL if window.location contains index.php #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume it was forgotten that this replace part should be renamed, after it was decided that index.html shall become index.php.
Currently I have to use a pretty ugly hack with the --body-html config
```
var getBaseUrl = Docs.controller.Content.prototype.getBaseUrl;
Docs.controller.Content.prototype.getBaseUrl = function(){
var r = getBaseUrl.apply(this,arguments);
r = r.replace('/index.php','');
return r;
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume it was forgotten that the getBaseUrl regular expression should be adapted, after it was decided that index.html shall become index.php.
Currently I have to use a pretty ugly hack with the --body-html config