[MOD] Resolved PR reviews

sendbird · May 15, 2023 · 4001025 · 4001025
1 parent bd4e056
commit 4001025
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 16 deletions.
diff --git a/ChatGPTExample/Controllers/ChatGPTChannelListViewController.swift b/ChatGPTExample/Controllers/ChatGPTChannelListViewController.swift
@@ -13,6 +13,7 @@ import SendbirdChatSDK
 /// ```swift
 /// SBUViewControllerSet.GroupChannelListViewController = ChatGPTChannelListViewController.self
 /// ```
+/// Refer to ``AppDelegate/updateViewControllerSet()``
 class ChatGPTChannelListViewController: SBUGroupChannelListViewController, BotTypeSelectorDelegate, SBUCreateChannelViewModelDelegate {
     var createChannelViewModel: SBUCreateChannelViewModel?
 

diff --git a/ChatGPTExample/Controllers/ChatGPTChannelSettingsViewController.swift b/ChatGPTExample/Controllers/ChatGPTChannelSettingsViewController.swift
@@ -8,6 +8,10 @@
 import UIKit
 import SendbirdUIKit
 
+/// ```swift
+/// SBUViewControllerSet.GroupChannelSettingsViewController = ChatGPTChannelSettingsViewController.self
+/// ```
+/// Refer to ``AppDelegate/updateViewControllerSet()``
 class ChatGPTChannelSettingsViewController: SBUGroupChannelSettingsViewController {
     override func showMemberList() {
         guard let channel = self.channel else { return }

diff --git a/ChatGPTExample/Controllers/ChatGPTChannelViewController.swift b/ChatGPTExample/Controllers/ChatGPTChannelViewController.swift
@@ -8,6 +8,10 @@
 import UIKit
 import SendbirdUIKit
 
+/// ```swift
+/// SBUViewControllerSet.GroupChannelViewController = ChatGPTChannelViewController.self
+/// ```
+/// Refer to ``AppDelegate/updateViewControllerSet()``
 class ChatGPTChannelViewController: SBUGroupChannelViewController {
     override func showChannelSettings() {
         guard let channel = self.channel else { return }

diff --git a/ChatGPTExample/Controllers/ChatGPTUserListViewController.swift b/ChatGPTExample/Controllers/ChatGPTUserListViewController.swift
@@ -8,6 +8,10 @@
 import UIKit
 import SendbirdUIKit
 
+/// ```swift
+/// SBUViewControllerSet.UserListViewController = ChatGPTUserListViewController.self
+/// ```
+/// Refer to ``AppDelegate/updateViewControllerSet()``
 class ChatGPTUserListViewController: SBUUserListViewController {
     override func viewDidLoad() {
         super.viewDidLoad()

diff --git a/ChatGPTExample/Model/ChatBot.swift b/ChatGPTExample/Model/ChatBot.swift
@@ -22,4 +22,19 @@ enum ChatBot: Int, CaseIterable {
             return "gpt_bot3"
         }
     }
+
+    var name: String {
+        switch self {
+        case .chatGPT:
+            return "GPT Bot"
+        case .witty:
+            return "Witty Bot"
+        case .knowledge:
+            return "Knowledge Bot"
+        }
+    }
+
+    var imageName: String {
+        "bot"
+    }
 }
diff --git a/ChatGPTExample/Views/BotTypeSelector.swift b/ChatGPTExample/Views/BotTypeSelector.swift
@@ -80,38 +80,35 @@ class BotTypeSelector: SBUCreateChannelTypeSelector {
         self.botSelectorDelegate?.botTypeSelector(self, didSelectBot: .chatGPT)
     }
 
-    @objc func onTapWittyBot() {
-        botSelectorDelegate?.botTypeSelector(self, didSelectBot: .witty)
+    @objc
+    func onTapWittyBot() {
+        self.botSelectorDelegate?.botTypeSelector(self, didSelectBot: .witty)
     }
 
-    @objc func onTapKnowledgeBot() {
-        botSelectorDelegate?.botTypeSelector(self, didSelectBot: .knowledge)
+    @objc
+    func onTapKnowledgeBot() {
+        self.botSelectorDelegate?.botTypeSelector(self, didSelectBot: .knowledge)
     }
 
 
     func createButton(botType: ChatBot) -> SBULayoutableButton {
         let button = SBULayoutableButton(gap: 4, labelAlignment: .under)
-//        let tintColor = theme.channelTypeSelectorItemTintColor
+        button.setTitle(botType.name, for: .normal)
+        button.setImage(UIImage(named: botType.imageName), for: .normal)
         switch botType {
         case .chatGPT:
-            button.setTitle("GPT Bot", for: .normal)
-            button.setImage(UIImage(named: "bot"), for: .normal)
             button.addTarget(
                 self,
                 action: #selector(onTapChatGPTBot),
                 for: .touchUpInside
             )
         case .witty:
-            button.setTitle("Witty Bot", for: .normal)
-            button.setImage(UIImage(named: "bot"), for: .normal)
             button.addTarget(
                 self,
                 action: #selector(onTapWittyBot),
                 for: .touchUpInside
             )
         case .knowledge:
-            button.setTitle("Knowledge Bot", for: .normal)
-            button.setImage(UIImage(named: "bot"), for: .normal)
             button.addTarget(
                 self,
                 action: #selector(onTapKnowledgeBot),
@@ -128,11 +125,7 @@ class BotTypeSelector: SBUCreateChannelTypeSelector {
 
     func updateButton(botType: ChatBot) {
         guard let button = self.viewWithTag(botType.rawValue + 10) as? UIButton else { return }
-        let tintColor = theme.channelTypeSelectorItemTintColor
-        switch botType {
-        default: button.setImage(UIImage(named: "bot"), for: .normal)
-        }
-
+        button.setImage(UIImage(named: botType.imageName), for: .normal)
         button.setTitleColor(theme.channelTypeSelectorItemTextColor, for: .normal)
         button.backgroundColor = self.theme.backgroundColor
     }