python version matrix #2

sensein · Sep 17, 2024 · 26ae2eb · 26ae2eb
1 parent 6eddfaa
commit 26ae2eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/cpu_tests.yaml → .github/workflows/macos_tests.yaml b/.github/workflows/cpu_tests.yaml → .github/workflows/macos_tests.yaml
@@ -1,4 +1,4 @@
-name: CPU Tests
+name: macOS Tests
 
 on:
   push:
@@ -13,8 +13,6 @@ jobs:
       fail-fast: true
       matrix:
         include:
-          # - {os: ubuntu-latest, architecture: x64, python-version: '3.10'}
-          # - {os: ubuntu-latest, architecture: x64, python-version: '3.11'}
           - {os: macos-latest, architecture: arm64, python-version: '3.10'}
           - {os: macos-latest, architecture: arm64, python-version: '3.11'}
     steps:

diff --git a/.github/workflows/gpu_tests.yaml → .github/workflows/ubuntu_tests.yaml b/.github/workflows/gpu_tests.yaml → .github/workflows/ubuntu_tests.yaml
@@ -1,14 +1,14 @@
-name: GPU Tests
+name: ubuntu Tests
 
 on:
   workflow_run:
-    workflows: ["CPU Tests"]  # Replace with the exact name of the CPU tests workflow
+    workflows: ["macOS Tests"]
     types:
       - completed
 
 jobs:
   start-runner:
-    if: ${{ github.event.workflow_run.conclusion == 'success' }} # Trigger only if CPU tests succeed
+    if: ${{ github.event.workflow_run.conclusion == 'success' }} # Trigger only if macOS tests succeed
     name: Start self-hosted EC2 runner for GPU
     runs-on: ubuntu-latest
     outputs:
@@ -40,7 +40,7 @@ jobs:
       matrix:
         python-version: ['3.10', '3.11']
     env:
-      POETRY_CACHE_DIR: /dev/shm
+      POETRY_CACHE_DIR: /dev/shm  # TODO: make this as a github variable!
     steps:
       - uses: actions/checkout@v4
         with: 
@@ -49,6 +49,8 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
+      - name: Echo python version
+        run: python --version
       - name: Install Poetry
         uses: snok/install-poetry@v1
       - name: Check space
@@ -68,7 +70,6 @@ jobs:
           poetry run nvidia-smi
           poetry run nvidia-smi -L
           poetry run nvidia-smi -q -d Memory
-          echo "DONE!!!!"
       - name: Run unit tests
         run: poetry run pytest
         shell: bash