Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TTS and convert voice feature #63

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

alistairewj
Copy link
Collaborator

Adds streamlit to the pyproject.toml as it is required now

This is redundant to #62 - but I'm testing the CI to see if requiring np <2 is explicitly required (streamlit says it doesn't support np >= 2 and it's unclear if any of our other packages do)

@alistairewj alistairewj force-pushed the alistair/add_streamlit_dependency branch from d7cae20 to 792a69d Compare June 24, 2024 21:17
@alistairewj alistairewj changed the title Add streamlit dependency Remove TTS and convert voice feature Jun 25, 2024
@alistairewj alistairewj force-pushed the alistair/add_streamlit_dependency branch from 2a71dd3 to 5d1c158 Compare June 25, 2024 16:28
@alistairewj
Copy link
Collaborator Author

Adding streamlit as a dependency and some experimentation exposed the following conflicts:

The conflict is caused by:
    b2aiprep 0+untagged.1.g5ba01ee depends on numpy==1.26.4
    streamlit 1.35.0 depends on numpy<2 and >=1.19.3
    transformers 4.39.3 depends on numpy>=1.17
    b2aiprep[dev,tts] 0+untagged.1.g5ba01ee depends on numpy==1.26.4
    tts 0.22.0 depends on numpy==1.22.0; python_version <= "3.10"

https://github.com/sensein/b2aiprep/actions/runs/9666011062/job/26664513604#step:4:368

After debugging, my view of the most reasonable solution was to remove the TTS package dependency. This means the CLI no longer supports converting a voice, which was a niche use anyway. The TTS package owners have recently shut down anyway: https://coqui.ai/

If we want to reimplement the feature, we probably need to use NeMo or something similar.

@alistairewj alistairewj requested a review from ibevers June 25, 2024 16:31
@alistairewj alistairewj merged commit e3f0ceb into main Jun 25, 2024
2 checks passed
@alistairewj alistairewj deleted the alistair/add_streamlit_dependency branch June 25, 2024 16:55
@DebuggerDan
Copy link
Contributor

Would Torchvision still be required as a dependency? (merge commit)

Currently, when running streamlit using the README.md example & the dataset, the b2aiprep-cli program outputs torchvision is not available - cannot save figures - I am assuming this might be a remnant library initialization from the TTS & voice conversion features, but asking to be sure!

@alistairewj
Copy link
Collaborator Author

Yes AFAIK we don't use any of the features from torchvision. This is reported by one of the imports, though not sure which one in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants