Add check for cpu-balance on RDS#218
Conversation
* Based on script check-ec2-cpu_balance.rb
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
a bit more future proofing and need a test artifact (ideally a unit test). If not a unit test I need a gist or something similar to show what you are passing via cli and its output to ensure that it does work.
| messages = "\n" | ||
| level = 0 | ||
| instances.db_instances.each do |db_instance| | ||
| next unless db_instance.db_instance_class.start_with? 'db.t2.' |
There was a problem hiding this comment.
I'd like this broken out as a param that we can check against a regex. My motivation is to not have to rewrite the plugin when t3's come out. It should ideally take a comma separated list and generate an array of regexes to do. Minimally a single regex exposed seems like the min requirement to not make this throw away when amazon bumps families. This unblocks user when it does break without waiting for a hotfix and release.
majormoses
added
Status: Awaiting Response
Type: Enhancement
and removed
Enhancement
labels
|
Just checking if you had plans to come back to this |
|
@majormoses |
|
Sounds good.
Please excuse brevity on mobile,
Ben Abrams
…On Dec 12, 2017 7:13 AM, "julio-ogury" ***@***.***> wrote:
@majormoses <https://github.com/majormoses>
Sorry for my late response.
I need to take time for this, maybe during this month.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#218 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC_9p_OWlzdZK2f7fzh43F8m9EbIpa2Aks5s_pgEgaJpZM4ONUbA>
.
|
|
@julio-ogury another friendly reminder |
|
Given that the user no longer exists I will merge this and we can refactor it later. |
|
I will have to come back to this one later since I am going to have to pull locally to fix conflict. |
1 participant
Pull Request Checklist
Is this in reference to an existing issue?
No
General
Update Changelog following the conventions laid out on Keep A Changelog
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
Check cpu-balance for RDS instance
Known Compatibility Issues