Fix listenbrainz track length submission and include submission client details #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the track length submission for ListenBrainz. ListenBrainz defines the fields
duration
andduration_ms
for this, see https://listenbrainz.readthedocs.io/en/latest/users/json.html . Without this information LB will not show a track length. It might also prematurely remove the "now playing" notification for longer tracks.As I understand from the code the track length is in seconds precision, hence the
duration
field is being used.duration_ms
would be for milliseconds.This PR also includes the fields
submission_client
as defined in the LB API docs linked above.