Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webui-path option and mux handler #428

Closed
wants to merge 2 commits into from

Conversation

tbmale
Copy link

@tbmale tbmale commented Dec 16, 2023

No description provided.

@tbmale
Copy link
Author

tbmale commented Dec 16, 2023

I'm in no way a golang programmer but this is schratcing my itch and I'm using it for my local instance, so I tought...

@sentriz
Copy link
Owner

sentriz commented Dec 16, 2023

what's the usecase for this?

@tbmale
Copy link
Author

tbmale commented Dec 17, 2023

what's the usecase for this?

There are several subsonic web frontends out there (jamstash,airsonic-refix,subplayer, etc.)

By doing -webui-path I can self-host the frontend from gonic.

@sentriz
Copy link
Owner

sentriz commented Dec 17, 2023

i would recommended having your reverse proxy with static file server host those. gonic can also read the GONIC_PROXY_PATH option to be aware of any path prefixes

hosting from gonic may also make it responsible for any security implications there. such as hosting two sites on the same domain, one of which isnt sanitising user input

@sentriz sentriz closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants