Skip to content

Commit

Permalink
Lint
Browse files Browse the repository at this point in the history
  • Loading branch information
eonist committed Nov 6, 2024
1 parent 22c43af commit 250103f
Show file tree
Hide file tree
Showing 6 changed files with 164 additions and 6 deletions.
159 changes: 159 additions & 0 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
only_rules:
# - force_unwrapping
# - force_cast
# - weak_computed_property
# - unused_private_declaration
- anyobject_protocol
- array_init
#- attributes
- block_based_kvo
- class_delegate_protocol
- closing_brace
- closure_end_indentation
- closure_parameter_position
- closure_spacing
- collection_alignment
- colon
- comma
- compiler_protocol_init
# - conditional_returns_on_newline
- contains_over_first_not_nil
- control_statement
- deployment_target
- discarded_notification_center_observer
- discouraged_direct_init
- discouraged_object_literal
- discouraged_optional_boolean
# - discouraged_optional_collection
- duplicate_imports
- dynamic_inline
- empty_count
- empty_enum_arguments
- empty_parameters
- empty_parentheses_with_trailing_closure
- empty_string
- empty_xctest_method
- explicit_init
- fallthrough
- fatal_error_message
- first_where
- for_where
- generic_type_name
- identical_operands
- identifier_name
- implicit_getter
- implicit_return
- inert_defer
- is_disjoint
- joined_default_parameter
- last_where
- leading_whitespace
- legacy_cggeometry_functions
- legacy_constant
- legacy_constructor
- legacy_hashing
- legacy_nsgeometry_functions
- legacy_random
- literal_expression_end_indentation
- lower_acl_than_parent
- mark
- modifier_order
# - multiline_arguments
# - multiline_function_chains
- multiline_literal_brackets
- multiline_parameters
- multiline_parameters_brackets
- multiple_closures_with_trailing_closure
- nimble_operator
- no_extension_access_modifier
- no_fallthrough_only
- notification_center_detachment
- number_separator
- object_literal
- opening_brace
- operator_usage_whitespace
- operator_whitespace
- overridden_super_call
- pattern_matching_keywords
- private_action
# - private_outlet
- private_unit_test
- prohibited_super_call
- protocol_property_accessors_order
- redundant_discardable_let
- redundant_nil_coalescing
- redundant_objc_attribute
- redundant_optional_initialization
- redundant_set_access_control
- redundant_string_enum_value
- redundant_type_annotation
- redundant_void_return
- required_enum_case
- return_arrow_whitespace
- shorthand_operator
- sorted_first_last
# - statement_position
- static_operator
# - strong_iboutlet
- superfluous_disable_command
- switch_case_alignment
# - switch_case_on_newline
- syntactic_sugar
- todo
- toggle_bool
- trailing_closure
- trailing_comma
- trailing_newline
- trailing_semicolon
- trailing_whitespace
#- type_name
# - unavailable_function
- unneeded_break_in_switch
- unneeded_parentheses_in_closure_argument
#- untyped_error_in_catch
- unused_closure_parameter
- unused_control_flow_label
- unused_enumerated
- unused_optional_binding
- unused_setter_value
- valid_ibinspectable
- vertical_parameter_alignment
- vertical_parameter_alignment_on_call
- vertical_whitespace_closing_braces
- vertical_whitespace_opening_braces
- void_return
- weak_delegate
- xct_specific_matcher
- xctfail_message
- yoda_condition
analyzer_rules:
- unused_import
number_separator:
minimum_length: 5
object_literal:
image_literal: false
discouraged_object_literal:
color_literal: false
identifier_name:
max_length:
warning: 100
error: 100
min_length:
warning: 0
error: 0
validates_start_with_lowercase: false
allowed_symbols:
- '_'
excluded:
- 'x'
- 'y'
- 'a'
- 'b'
- 'x1'
- 'x2'
- 'y1'
- 'y2'
# macOS_deployment_target: '10.12'
excluded: # paths to ignore during linting. Takes precedence over `included`.
- 'Packages/External/SwiftDraw'
- 'Packages/External'
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ let package = Package(
targets: ["MockGen"])
],
dependencies: [
.package(url: "https://github.com/eonist/JSONSugar.git", branch: "master"),
.package(url: "https://github.com/eonist/JSONSugar.git", branch: "master")
// .package(url: "https://github.com/sentryco/Logger.git", branch: "main")
],
targets: [
Expand Down
2 changes: 1 addition & 1 deletion Sources/MockGen/MockGen+Util.swift
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ extension MockGen {
*/
public static func getRandomBool(_ chance: Int) -> Bool {
(0...chance) // Create a range from 0 to the specified chance value
.filter({ (_: Int) in Bool.random() }) // Filter the range to include only values where a random boolean value is true
.filter { (_: Int) in Bool.random() } // Filter the range to include only values where a random boolean value is true
.isEmpty // Check if the resulting array is empty (i.e. if any values passed the filter)
}
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/MockGen/util/random/CodeGen.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public enum CodeGen {
letters += specialChars
}
let characters: [String.Element] = Array(letters) // Convert the set of characters to an array
let numChars: UInt32 = UInt32(characters.count) // Get the number of characters in the array
let numChars = UInt32(characters.count) // Get the number of characters in the array
let result: String = .init((0..<length).map { (_: Int) in // Generate a random password string of the given length using the set of characters
characters[Int(arc4random_uniform(numChars))]
})
Expand Down
1 change: 0 additions & 1 deletion Sources/MockGen/util/random/SecRan.swift
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,3 @@ public class SecRan {
}
}
#endif

4 changes: 2 additions & 2 deletions Tests/MockGenTests/MockGenTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,14 @@ extension MockGenTests {
* - Description: This test verifies that the `randomPassword` function generates a password of the specified length and that the length of the generated password matches the expected value.
*/
fileprivate static func testRandomPassword() {
let password: String = String.randomPassword(pwdLength: 64)
let password = String.randomPassword(pwdLength: 64)
XCTAssertEqual(password.count, 64, "Password length is not correct.")
}
/**
* - Description: This test verifies that the `random` function generates a string of the specified length and that the length of the generated string matches the expected value.
*/
fileprivate static func testRandom() {
let randomString: String = String.random(length: 88)
let randomString = String.random(length: 88)
XCTAssertEqual(randomString.count, 88, "Random string length is not correct.")
}
}

0 comments on commit 250103f

Please sign in to comment.