Issue #59: Display the connector variables #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a `variables` section under the `prerequisites` in the connectors pages to display the connector template variables, their description & their default value if available. * Tested on metricshub-doc.
* Updated MetricsHub example content producer to add variables configuration example. * Tested the results
* Resolved merge conflict.
|
I would simplify the listing of variables like below: Variables:
So the "template" is like: <li> <code>VARNAME</code>: VARDESCRIPTION (default: <code>DEFAULTVALUE</code>)Description and default value should be displayed in the doc only if they are specified, like below:
|
|
Now an interesting question: how do we specify variable values for a connector through the CLI? 😅 |
|
There is a plan for this @bertysentry sentrysoftware/metricshub#357... indeed, we still require a spec. |
NassimBtk
requested changes
Sep 27, 2024
| final String variableRegex = "\\$\\{var::(.*?)\\}"; | ||
| final Set<String> variables = new HashSet<>(); | ||
|
|
||
| final Pattern pattern = Pattern.compile(variableRegex); |
| @@ -0,0 +1,42 @@ | |||
| package org.sentrysoftware.maven.metricshub.connector.producer.model.common; | |||
|
|
|||
| import lombok.AllArgsConstructor; | |||
There was a problem hiding this comment.
Should be under the ╱╲╱╲╱╲ header comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variablessection under theprerequisitesin the connectors pages to display the connector template variables, their description & their default value if available.Tests
Default connector variables specified.
Default connector variables not specified (variables are present).
MetricsHub.yaml example