Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to filter monitors #423

Closed
NassimBtk opened this issue Sep 23, 2024 · 0 comments · Fixed by #446
Closed

Add the ability to filter monitors #423

NassimBtk opened this issue Sep 23, 2024 · 0 comments · Fixed by #446
Assignees
@TNohaic
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v0.9.07

Comments

@NassimBtk
Copy link
Member

NassimBtk commented Sep 23, 2024 •
edited
Loading

Needs

Add the ability to include or exclude monitored instances.

Specification

The user should be able to specify a set of monitors to be included or excluded.

A match type using + and ! notations should be implemented.

The engine/hardware strategies (Discovery, Collect, Simple, Hardware.*) need to be updated in order to apply the filter.

We need to provide a filtering section under the resource, resource group or even globally in metricshsub.yaml.

Add a new configuration property in metricshub.yaml: monitorFilters.
@NassimBtk NassimBtk changed the title Ability to disable monitors Ability to filter monitors Sep 23, 2024
@NassimBtk NassimBtk added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 23, 2024
@NassimBtk NassimBtk assigned TNohaic and unassigned CherfaElyes Oct 4, 2024
TNohaic added a commit that referenced this issue Oct 10, 2024
@TNohaic
Issue #423
b7ef077 
Add the possibility to filter monitors in the configuration file.
@TNohaic TNohaic linked a pull request Oct 10, 2024 that will close this issue
Issue #423: Add the ability to include or exclude monitored instances #446
Merged
TNohaic added a commit that referenced this issue Oct 11, 2024
@TNohaic
Issue #423
ec11c25 
Correction after PR review
TNohaic added a commit that referenced this issue Oct 11, 2024
@TNohaic
Issue #423
588aca5 
Correction after PR review
TNohaic added a commit that referenced this issue Oct 11, 2024
@TNohaic
Issue #423
75b1753 
Add documentation.
NassimBtk added a commit that referenced this issue Oct 11, 2024
@NassimBtk
Issue #423: Ability to filter monitors
841785a 
Enhanced documentation.
NassimBtk added a commit that referenced this issue Oct 11, 2024
@NassimBtk
Issue #423: Ability to filter monitors
d5c904d 
* Fixed HostConfiguration.
NassimBtk added a commit that referenced this issue Oct 11, 2024
@NassimBtk
Merge pull request #446 from sentrysoftware/feature/issue-423-ability…
7cbf0cc 
…-to-filter-monitors

Issue #423: Add the ability to include or exclude monitored instances
@NassimBtk NassimBtk reopened this Oct 11, 2024
@NassimBtk NassimBtk added this to the v0.9.07 milestone Oct 11, 2024
@NassimBtk NassimBtk changed the title Ability to filter monitors Add the ability to filter monitors Oct 11, 2024
NassimBtk added a commit that referenced this issue Oct 11, 2024
@NassimBtk
Issue #444: Write the release notes
c086ef5 
* Updated RN to show issue: #423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TNohaic TNohaic

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.9.07
Development

Successfully merging a pull request may close this issue.

Issue #423: Add the ability to include or exclude monitored instances sentrysoftware/metricshub
3 participants
@NassimBtk @TNohaic @CherfaElyes