Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #423: Add the ability to include or exclude monitored instances #446

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Issue #423: Add the ability to include or exclude monitored instances #446

merged 7 commits into from
Oct 11, 2024

Conversation

TNohaic
Copy link
Contributor

@TNohaic TNohaic commented Oct 10, 2024

Add the possibility to filter monitors in the configuration file.
Without filtering:
Capture_with_physical_disks
When filtering the physical disks:
Capture_without_physical_disks

@TNohaic
Issue #423
b7ef077 
Add the possibility to filter monitors in the configuration file.
@TNohaic TNohaic linked an issue Oct 10, 2024 that may be closed by this pull request
Add the ability to filter monitors #423
Closed
@NassimBtk NassimBtk changed the title Issue #423 Issue #423: Add the ability to include or exclude monitored instances. Oct 10, 2024
NassimBtk
NassimBtk reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@NassimBtk NassimBtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during the call, a few updates will come soon.

@NassimBtk NassimBtk changed the title Issue #423: Add the ability to include or exclude monitored instances. Issue #423: Add the ability to include or exclude monitored instances Oct 11, 2024
@TNohaic
Issue #423
588aca5 
Correction after PR review
@TNohaic
Issue #423
75b1753 
Add documentation.
@NassimBtk NassimBtk self-requested a review October 11, 2024 16:49
@NassimBtk NassimBtk merged commit 7cbf0cc into main Oct 11, 2024
2 checks passed
@NassimBtk NassimBtk deleted the feature/issue-423-ability-to-filter-monitors branch October 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NassimBtk NassimBtk NassimBtk approved these changes

@MedMaalej MedMaalej Awaiting requested review from MedMaalej

@MarcDouguedroit MarcDouguedroit Awaiting requested review from MarcDouguedroit

@bertysentry bertysentry Awaiting requested review from bertysentry

@NathalieLe NathalieLe Awaiting requested review from NathalieLe

@CherfaElyes CherfaElyes Awaiting requested review from CherfaElyes

@SafaeAJ SafaeAJ Awaiting requested review from SafaeAJ

@iguitton iguitton Awaiting requested review from iguitton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to filter monitors
2 participants
@TNohaic @NassimBtk