Issue #427: Add status information to connector monitor #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MedMaalej
commented
Sep 27, 2024
MedMaalej
commented
- Add buildStatusInformation in AbstractStrategy
- Set StatusInformation in the legacyTextParams attribute (map) of the connector monitor
- Update unit tests
* Update validateConnectorDetectionCriteria to put StatusInformation in the legacyTextParameters monitor attribute map of the connector monitor * Add unit tests assertions in DiscoveryStrategyTest, SimpleStrategyTest and CollectStrategyTest
* Update validateConnectorDetectionCriteria * Update unit tests
…ure/issue-427-Add-statutusInformation-to-connector-monitor
MedMaalej
requested review from
NassimBtk,
MarcDouguedroit,
bertysentry,
TNohaic,
FK-sentry,
CherfaElyes and
SafaeAJ
|
This feature was tested locally using the connector 
|
NassimBtk
requested changes
Sep 27, 2024
| // Check that StatusInformation is collected on the connector monitor (criterion processing success case) | ||
| assertEquals( | ||
| "Received Result: 1.3.6.1.4.1.795.10.1.1.3.1.1.0\tASN_OCTET_STR\tTest. SnmpGetNextCriterion test succeeded:\n" + | ||
| "SnmpGetNextCriterion(super=SnmpCriterion(super=Criterion(type=snmpGetNext, forceSerialization=false), oid=1.3.6.1.4.1.795.10.1.1.3.1.1, expectedResult=null))\n" + |
There was a problem hiding this comment.
Can you please @MedMaalej update the toString() method on DeviceTypeCriterion, HttpCriterion, ProcessCriterion, ProductRequirementsCriterion and SnmpCriterion. Please use the same pattern as on CommandLineCriterion. Thanks.
iguitton
changed the title
* Override toString method in DeviceTypeCriterion, HttpCriterion, ProcessCriterion, ProductRequirementsCriterion and SnmpCriterion * Update unit tests
NassimBtk
requested changes
Sep 30, 2024
| // Check that StatusInformation is collected on the connector monitor (criterion processing failure case) | ||
| assertEquals( | ||
| "Received Result: 1.3.6.1.4.1.795.10.1.1.3.1.1.0\tASN_OCTET_STR\tTest. SnmpGetNextCriterion test ran but failed:\n" + | ||
| "SnmpGetNextCriterion(super=- OID: 1.3.6.1.4.1.795.10.1.1.3.1.1)\n" + |
There was a problem hiding this comment.
Sorry we need to call super.toString() in toString() of SnmpGetNextCriterion and SnmpGetCriterion .
NassimBtk
requested changes
Sep 30, 2024
| .map(criterionResult -> { | ||
| final String result = criterionResult.getResult(); | ||
| final String message = criterionResult.getMessage(); | ||
| return String.format( |
There was a problem hiding this comment.
Each extension provides the messages in a specific format. We need to normalize all the messages. It is a huge work but we should do that to get normalized messages for BMC or even for OTEL logs.
Created issue: #432
|
Also @MedMaalej how is the |
…ure/issue-427-Add-statutusInformation-to-connector-monitor
* Update buildstatusInformation
* Update CLI display of text parameters * Update unit tests
…ure/issue-427-Add-statutusInformation-to-connector-monitor
MedMaalej
force-pushed
the
feature/issue-427-Add-statutusInformation-to-connector-monitor
branch
from
fd80d40
to
3a7de5a
Compare
NassimBtk
requested changes
Oct 8, 2024
| @@ -41,6 +43,7 @@ | |||
| import org.sentrysoftware.metricshub.engine.telemetry.metric.NumberMetric; | |||
|
|
|||
| @ExtendWith(MockitoExtension.class) | |||
| @Disabled | |||
| @@ -46,6 +48,7 @@ | |||
| import org.sentrysoftware.metricshub.engine.telemetry.TelemetryManager; | |||
|
|
|||
| @ExtendWith(MockitoExtension.class) | |||
| @Disabled | |||
| @@ -53,6 +54,7 @@ | |||
| import org.sentrysoftware.metricshub.engine.telemetry.metric.NumberMetric; | |||
|
|
|||
| @ExtendWith(MockitoExtension.class) | |||
| @Disabled | |||
* Remove disabled annotation from strategy tests
NassimBtk
approved these changes
Oct 8, 2024
NassimBtk
deleted the
feature/issue-427-Add-statutusInformation-to-connector-monitor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.