-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #422: Rename SQL Source Module to localSql Source #443
Merged
NassimBtk
merged 7 commits into
main
from
feature/issue-422-rename-sql-source-module-to-localSql
Oct 10, 2024
Merged
Issue #422: Rename SQL Source Module to localSql Source #443
NassimBtk
merged 7 commits into
main
from
feature/issue-422-rename-sql-source-module-to-localSql
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-422-rename-sql-source-module-to-localSql
…-422-rename-sql-source-module-to-localSql
fix pom.xml
NassimBtk
requested changes
Oct 9, 2024
NassimBtk
requested changes
Oct 9, 2024
NassimBtk
requested changes
Oct 9, 2024
* Fix README.md and pom.xml
NassimBtk
approved these changes
Oct 10, 2024
NassimBtk
deleted the
feature/issue-422-rename-sql-source-module-to-localSql
branch
October 10, 2024 14:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request focuses on renaming the
SqlSource
class and related components toLocalSqlSource
across the project. This change affects multiple files, including source code, test files, and configuration files.Renaming
SqlSource
toLocalSqlSource
:Source Code Changes:
SqlSource
class toLocalSqlSource
inmetricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/connector/model/monitor/task/source/LocalSqlSource.java
.Source
class to referenceLocalSqlSource
instead ofSqlSource
inmetricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/connector/model/monitor/task/source/Source.java
.ISourceProcessor
interface andSourceProcessor
class to useLocalSqlSource
.SourceUpdaterProcessor
to processLocalSqlSource
.Test Files Changes:
SqlSource
toLocalSqlSource
inmetricshub-engine/src/test/java/org/sentrysoftware/metricshub/engine/connector/deserializer/source/LocalSqlSourceDeserializerTest.java
.SourceProcessorTest
to handleLocalSqlSource
.Configuration and Documentation Changes:
README.md
to reflect the new extension namemetricshub-localsql-source-extension
.metricshub-localsql-source-extension
.localSql
inmetricshub-engine/src/test/resources/test-files/source/sql/localSqlSource.yaml
.