Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #422: Rename SQL Source Module to localSql Source #443

Merged

Conversation

SafaeAJ
Copy link
Contributor

@SafaeAJ SafaeAJ commented Oct 9, 2024

  • Update Source, IsourceProcessor, SourceProcessor, SourceUpdaterProcessor, pom.xml in (linux, windows) and README.md
  • Tested using the Hitachi connector.

Capture d'écran 2024-10-09 143155
Capture d'écran 2024-10-09 160005

Summary

This pull request focuses on renaming the SqlSource class and related components to LocalSqlSource across the project. This change affects multiple files, including source code, test files, and configuration files.

Renaming SqlSource to LocalSqlSource:

  • Source Code Changes:

    • Renamed SqlSource class to LocalSqlSource in metricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/connector/model/monitor/task/source/LocalSqlSource.java.
    • Updated Source class to reference LocalSqlSource instead of SqlSource in metricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/connector/model/monitor/task/source/Source.java.
    • Adjusted ISourceProcessor interface and SourceProcessor class to use LocalSqlSource.
    • Updated SourceUpdaterProcessor to process LocalSqlSource.
  • Test Files Changes:

    • Renamed test classes and updated references from SqlSource to LocalSqlSource in metricshub-engine/src/test/java/org/sentrysoftware/metricshub/engine/connector/deserializer/source/LocalSqlSourceDeserializerTest.java.
    • Modified SourceProcessorTest to handle LocalSqlSource.
  • Configuration and Documentation Changes:

    • Updated README.md to reflect the new extension name metricshub-localsql-source-extension.
    • Renamed POM files and updated artifact IDs to metricshub-localsql-source-extension.
    • Renamed YAML configuration file and updated type to localSql in metricshub-engine/src/test/resources/test-files/source/sql/localSqlSource.yaml.

README.md Outdated Show resolved Hide resolved
metricshub-windows/pom.xml Outdated Show resolved Hide resolved
metricshub-linux/pom.xml Outdated Show resolved Hide resolved
@NassimBtk NassimBtk linked an issue Oct 10, 2024 that may be closed by this pull request
@SafaeAJ SafaeAJ added this to the v0.9.07 milestone Oct 10, 2024
@NassimBtk NassimBtk merged commit 5fada77 into main Oct 10, 2024
2 checks passed
@NassimBtk NassimBtk deleted the feature/issue-422-rename-sql-source-module-to-localSql branch October 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop SQL Extension
2 participants