Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits on line functionality #285

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

#272

What does this implement/fix? Explain your changes.

Minor edits in test systems, error messages, and readme.

Note: readme was already updated so this PR won't update that file.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri
Thanks for your effort 💯
Please take a look at my comments

README.md Outdated Show resolved Hide resolved
art/params.py Outdated Show resolved Hide resolved
art/params.py Outdated Show resolved Hide resolved
@sadrasabouri
Copy link
Collaborator Author

All fixed, please re-review it @sepandhaghighi

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 5adf215 into dev Nov 14, 2024
27 checks passed
@sepandhaghighi sepandhaghighi deleted the minor-edits-on-line-funtionality branch November 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants