Skip to content

fix in fragment ,tips will not be close #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix in fragment ,tips will not be close #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions library/src/main/java/it/sephiroth/android/library/tooltip/TooltipManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ public class TooltipManager {
private static final String TAG = "TooltipManager";
private volatile static TooltipManager INSTANCE;

private TooltipManager() {}
private TooltipManager() {
}

public static synchronized TooltipManager getInstance() {
if (INSTANCE == null) {
Expand All @@ -45,6 +46,10 @@ public void onClose(final TooltipView layout) {
if (DBG) {
Log.i(TAG, "onClose: " + layout.getTooltipId());
}
//if in the fragment mTooltips will be null,then it can't be close, i dont' know why.
if (mTooltips.size() == 0) {
mTooltips.put(layout.getTooltipId(), new WeakReference<>(layout));
}
hide(layout.getTooltipId());
}
};
Expand Down Expand Up @@ -234,7 +239,7 @@ private void showInternal(View rootView, TooltipView layout, boolean immediate)
Log.v(TAG, "attach to mToolTipLayout parent");
}
ViewGroup.LayoutParams params =
new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT);
new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT);
((ViewGroup) rootView).addView(layout, params);
}

Expand Down