2025 11 15 96o6 91a92#70
Merged
Merged
Conversation
Merge pull request #68 from seqasim/2025-11-15-96o6-91a92
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: NameError: Variable from Unquoted String
The condition elif entorhinal in roi: references an undefined variable entorhinal (missing quotes). This should be the string 'entorhinal' to check if the string is in the roi list. This will cause a NameError at runtime when this branch is executed.
LFPAnalysis/analysis_utils.py#L154-L155
LFPAnalysis/LFPAnalysis/analysis_utils.py
Lines 154 to 155 in 473232a
| spikes - raw spike times used to compute STA, should be in s | ||
| signal - signal for averaging. can be filtered or unfiltered. | ||
| bound - bound of the STA in ms, +- this number | ||
| def lfp_sta(ev_times: np.ndarray, signal: np.ndarray, sr: float, pre: float, post: float): |
| spikes - raw spike times used to compute STA, should be in s | ||
| signal - signal for averaging. can be filtered or unfiltered. | ||
| bound - bound of the STA in ms, +- this number | ||
| def lfp_sta(ev_times: np.ndarray, signal: np.ndarray, sr: float, pre: float, post: float): |
seqasim
added a commit
that referenced
this pull request
Nov 15, 2025
Merge pull request #70 from seqasim/2025-11-15-96o6-91a92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accidental branch - merge
Note
Add comprehensive type hints and docstrings plus a suite of LFP analysis utilities (preprocessing/baseline, BOSC/eBOSC, connectivity incl. GC/GCMI and amp coupling, FOOOF, synchronization, NLX/IOWA parsing, and permutation/mixed-effects stats).
Written by Cursor Bugbot for commit 473232a. This will update automatically on new commits. Configure here.