-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve container credentials retrieval matching container repository names #278
base: master
Are you sure you want to change the base?
improve container credentials retrieval matching container repository names #278
Conversation
munishchouhan
commented
Aug 8, 2023
•
edited
Loading
edited
- wave should support repository credential validation
- Wave should choose the best matching credentials from the tower for a give registry/repository name
…er-credentials-retrieval-matching-container-repository-names
src/main/groovy/io/seqera/wave/auth/RegistryAuthServiceImpl.groovy
Outdated
Show resolved
Hide resolved
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…er-credentials-retrieval-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
@pditommaso pinging you on this one - can you provide an output on any dependency that is holding this PR? thank you :-) |
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
1a7df00
to
4fbf3bb
Compare
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
…l-matching-container-repository-names
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8498070 | Triggered | Username Password | f8eed91 | src/test/groovy/io/seqera/wave/auth/RegistryCredentialsProviderTest.groovy | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…l-matching-container-repository-names
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
…l-matching-container-repository-names
…l-matching-container-repository-names