Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v2.1.0 #913

Merged
merged 1 commit into from
Feb 15, 2021
Merged

chore(release): v2.1.0 #913

merged 1 commit into from
Feb 15, 2021

Conversation

theoludwig
Copy link
Contributor

@theoludwig theoludwig commented Feb 14, 2021

What changes this PR introduce ?

  • Delete Cache dependencies step in CI so hopefully it solves the issue with the CI failing (as discussed in Gitter chat)
  • Downgrade sqlite3 from 5.0.1 to 5.0.0 since [email protected] have issues. See: Failed at the [email protected] install script. TryGhost/node-sqlite3#1424
  • Add husky so everytime we commit, it verify the commit message, and run npm run lint also to avoid installing husky when installing the package, we use pinst made by the creator of husky. See: https://github.com/typicode/pinst
  • Add release-it and commitlint so it generates the changelog automatically based on commit messages also automatically choose the version number to increase based on semver.
  • Add markdownlint, see: https://github.com/DavidAnson/markdownlint
  • Cleanup the README, so we only display how to use the package for the current latest version, if users want to know how to use it for older versions of TypeScript they can see in the Changelog.

Is there anything you'd like reviewers to focus on?

Once this PR has been merged, we could create a new release on GitHub, so it automatically release a new version on npm if you set correctly NPM_TOKEN secret as it was suggested in this PR: #871.

We should use https://github.com/zeke/semantic-pull-requests.

Note: Git is showing a large number of changes but in fact, it's because I installed a few new dependencies so package-lock.json has lot of changes.

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #913 (f84f594) into master (1bb4e71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         117      117           
  Lines        1127     1127           
  Branches      129      129           
=======================================
  Hits         1073     1073           
  Misses         22       22           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb4e71...f84f594. Read the comment docs.

Copy link
Member

@RobinBuschmann RobinBuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukashroch lukashroch self-requested a review February 14, 2021 22:06
@theoludwig theoludwig merged commit f3ee651 into master Feb 15, 2021
@theoludwig theoludwig deleted the release/v2.1.0 branch February 15, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants