Skip to content

Update bindgen 0.63.0 -> 0.71.1 (#116)#118

Merged
m-dahl merged 1 commit intosequenceplanner:masterfrom
beuss-git:fix-bindgen
Apr 17, 2025
Merged

Update bindgen 0.63.0 -> 0.71.1 (#116)#118
m-dahl merged 1 commit intosequenceplanner:masterfrom
beuss-git:fix-bindgen

Conversation

@beuss-git
Copy link
Contributor

bindgen 0.63.0 didn't expand/include the following macros on some systems:

// {ROS_BASE}/include/rosidl_runtime_c/rosidl_runtime_c/primitives_sequence_functions.h
...
ROSIDL_RUNTIME_C__DECLARE_PRIMITIVE_SEQUENCE_FUNCTIONS(float)
ROSIDL_RUNTIME_C__DECLARE_PRIMITIVE_SEQUENCE_FUNCTIONS(double)
ROSIDL_RUNTIME_C__DECLARE_PRIMITIVE_SEQUENCE_FUNCTIONS(long_double)
...

This change fixes this by now generating the missing primitive sequence functions.
I have manually tested it to compile and work on Ubuntu 22.04 with ROS2 Humble and Iron using some simple messages.

This fixes sequenceplanner#116 by now generating the missing primitive sequence functions.
Tested to be working on Ubuntu 22.04 with ROS2 Humble and Iron.
@wentasah
Copy link
Contributor

Cool. Which rust version do you use? When I'm trying this with 1.85.0, I'm getting this error: rust-lang/rust-bindgen#3149. When I downgrade bindgen to 0.70.0, as suggested in that issue, it works.

@beuss-git
Copy link
Contributor Author

Hmm, that's a bit unfortunate.
I am pretty close in version to you.

$ rustc --version
rustc 1.85.1 (4eb161250 2025-03-15)

@wentasah
Copy link
Contributor

I found the source of my problem. I had to update proc-macro2 by running cargo update proc-macro2 --precise 1.0.80. See rust-lang/rust-bindgen#3149 (comment).

@m-dahl
Copy link
Collaborator

m-dahl commented Apr 1, 2025

Hello. Thanks! I will merge this shortly. But then we should update again once bindgen releases a new version I guess.

@aboseley
Copy link

I've been seeing the same issue today using rust 1.85.1, upgrading to this branch fixed my issue. Thank you.

@m-dahl m-dahl merged commit 56acba5 into sequenceplanner:master Apr 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants