Fixed failing ros2 param ... on r2r nodes for Jazzy#120
Merged
m-dahl merged 4 commits intosequenceplanner:set_params_atomicfrom Apr 17, 2025
des256:master
Merged
Fixed failing ros2 param ... on r2r nodes for Jazzy#120m-dahl merged 4 commits intosequenceplanner:set_params_atomicfrom des256:master
ros2 param ... on r2r nodes for Jazzy#120m-dahl merged 4 commits intosequenceplanner:set_params_atomicfrom
des256:master
Conversation
…e_parameter_handler_internal` in `nodes.rs`.
Contributor
|
I think, that the implementation should contain a note or a TODO that the service is not implemented according to specification:
If the request contains multiple parameters, the request will currently set some parameters up to a failing one, (the assignment can fail, e.g., if the parameter does not match the type of a used derived struct). |
Contributor
Author
|
Yep. Added a warning message for further implementation. |
Collaborator
|
Thanks for the fix! I want to change it so it behaves according to the spec before we merge it into main, otherwise we will forget and it will lead to confusion some day. Let's continue here: #121 |
m-dahl
added a commit
that referenced
this pull request
Apr 22, 2025
* Fixed failing `ros2 param ...` on r2r nodes for Jazzy (#120) Add `/set_parameters_atomically` service to `make_parameter_handler_internal` in `nodes.rs` to fix failing `ros2 param ...` on r2r nodes for Jazzy. * Atomic behavior for `set_parameters_atomically` (#121). --------- Co-authored-by: Desmond Germans <desmond@germansmedia.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jazzy requires an additional
/set_parameters_atomicallyservice to be present on the node. If not found,ros2 param ...won't work with a message similar to:Wait for service timed out waiting for parameter services for node NodeName(name='to_be_replaced', namespace='/to_be_replaced', full_name='/to_be_replaced/to_be_replaced')I added this service to
r2rand nowros2 param ...works again.