Merge pull request #219 Fix shutting down walletd

seredat · May 27, 2023 · a72eed0 · a72eed0
2 parents 3df16d3 + d83cef6
commit a72eed0
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 19 deletions.
diff --git a/src/JsonRpcServer/JsonRpcServer.cpp b/src/JsonRpcServer/JsonRpcServer.cpp
@@ -42,7 +42,7 @@
 
 namespace CryptoNote {
 
-JsonRpcServer::JsonRpcServer(System::Dispatcher& sys, System::Event& stopEvent, Logging::ILogger& loggerGroup) :
+JsonRpcServer::JsonRpcServer(System::Dispatcher* sys, System::Event* stopEvent, Logging::ILogger& loggerGroup) :
   m_dispatcher(sys),
   stopEvent(stopEvent),
   logger(loggerGroup, "JsonRpcServer"),
@@ -56,16 +56,12 @@ JsonRpcServer::~JsonRpcServer() {
 
 void JsonRpcServer::start(const std::string& bindAddress, uint16_t bindPort, uint16_t bindPortSSL) {
   if (m_enable_ssl) {
-    m_workers.emplace_back(std::unique_ptr<System::RemoteContext<void>>(
-      new System::RemoteContext<void>(m_dispatcher, std::bind(&JsonRpcServer::listen_ssl, this, bindAddress, bindPortSSL)))
-    );
+    m_workers.push_back(std::thread(std::bind(&JsonRpcServer::listen_ssl, this, bindAddress, bindPortSSL)));
   }
 
-  m_workers.emplace_back(std::unique_ptr<System::RemoteContext<void>>(
-    new System::RemoteContext<void>(m_dispatcher, std::bind(&JsonRpcServer::listen, this, bindAddress, bindPort)))
-  );
+  m_workers.push_back(std::thread(std::bind(&JsonRpcServer::listen, this, bindAddress, bindPort)));
 
-  stopEvent.wait();
+  stopEvent->wait();
 }
 
 void JsonRpcServer::stop() {
@@ -75,10 +71,19 @@ void JsonRpcServer::stop() {
 
   http->stop();
 
-  m_dispatcher.remoteSpawn([this]
-  {
-    stopEvent.set();
-  });
+  if (m_dispatcher != nullptr) {
+    m_dispatcher->remoteSpawn([&]() {
+      if (stopEvent != nullptr) {
+        stopEvent->set();
+      }
+    });
+  }
+
+  for (auto& th : m_workers) {
+    if (th.joinable()) {
+      th.join();
+    }
+  }
 
   m_workers.clear();
 }

diff --git a/src/JsonRpcServer/JsonRpcServer.h b/src/JsonRpcServer/JsonRpcServer.h
@@ -20,6 +20,7 @@
 #pragma once
 
 #include <system_error>
+#include <thread>
 
 #include "System/Dispatcher.h"
 #include "System/Event.h"
@@ -46,7 +47,7 @@ namespace CryptoNote {
 
 class JsonRpcServer {
 public:
-  JsonRpcServer(System::Dispatcher& sys, System::Event& stopEvent, Logging::ILogger& loggerGroup);
+  JsonRpcServer(System::Dispatcher* sys, System::Event* stopEvent, Logging::ILogger& loggerGroup);
   JsonRpcServer(const JsonRpcServer&) = delete;
 
   ~JsonRpcServer();
@@ -74,13 +75,13 @@ class JsonRpcServer {
   void listen_ssl(const std::string address, const uint16_t port);
   bool authenticate(const httplib::Request& request) const;
 
-  System::Dispatcher& m_dispatcher;
-  System::Event& stopEvent;
+  System::Dispatcher* m_dispatcher;
+  System::Event* stopEvent;
   Logging::LoggerRef logger;
   httplib::Server* http;
   httplib::SSLServer* https;
 
-  std::vector<std::unique_ptr<System::RemoteContext<void>>> m_workers;
+  std::list<std::thread> m_workers;
 
   std::string m_chain_file;
   std::string m_key_file;

diff --git a/src/PaymentGate/PaymentServiceJsonRpcServer.cpp b/src/PaymentGate/PaymentServiceJsonRpcServer.cpp
@@ -32,7 +32,7 @@
 
 namespace PaymentService {
 
-PaymentServiceJsonRpcServer::PaymentServiceJsonRpcServer(System::Dispatcher& sys, System::Event& stopEvent, WalletService& service, Logging::ILogger& loggerGroup) 
+PaymentServiceJsonRpcServer::PaymentServiceJsonRpcServer(System::Dispatcher* sys, System::Event* stopEvent, WalletService& service, Logging::ILogger& loggerGroup) 
   : JsonRpcServer(sys, stopEvent, loggerGroup)
   , service(service)
   , logger(loggerGroup, "PaymentServiceJsonRpcServer")

diff --git a/src/PaymentGate/PaymentServiceJsonRpcServer.h b/src/PaymentGate/PaymentServiceJsonRpcServer.h
@@ -34,7 +34,7 @@ class WalletService;
 
 class PaymentServiceJsonRpcServer : public CryptoNote::JsonRpcServer {
 public:
-  PaymentServiceJsonRpcServer(System::Dispatcher& sys, System::Event& stopEvent, WalletService& service, Logging::ILogger& loggerGroup);
+  PaymentServiceJsonRpcServer(System::Dispatcher* sys, System::Event* stopEvent, WalletService& service, Logging::ILogger& loggerGroup);
   PaymentServiceJsonRpcServer(const PaymentServiceJsonRpcServer&) = delete;
 
 protected:

diff --git a/src/PaymentGateService/PaymentGateService.cpp b/src/PaymentGateService/PaymentGateService.cpp
@@ -325,7 +325,7 @@ void PaymentGateService::runWalletService(const CryptoNote::Currency& currency,
     }
   } else {
 
-    PaymentService::PaymentServiceJsonRpcServer rpcServer(*dispatcher, *stopEvent, *service, logger);
+    PaymentService::PaymentServiceJsonRpcServer rpcServer(dispatcher, stopEvent, *service, logger);
 
     bool rpc_run_ssl = false;
     std::string rpc_chain_file = "";