Fix matches_qualname() not to stop at first matching name

serge-sans-paille · Oct 29, 2024 · c18ce26 · c18ce26
1 parent ef8f161
commit c18ce26
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/beniget/beniget.py b/beniget/beniget.py
@@ -476,7 +476,7 @@ def matches_qualname(*, heads, locals, imports, modnames, expr, qnames):
                 return True
             else:
                 # localy defined name, but module name doesn't match
-                break
+                continue
 
     elif isinstance(expr, ast.Attribute):
         for n in qnames:

diff --git a/tests/test_chains.py b/tests/test_chains.py
@@ -1411,6 +1411,25 @@ def test_stubs_typealias_typing_pyi(self):
                 filename='typing.pyi',
             )
 
+    def test_stubs_conditionnal_typealias(self):
+        code = '''
+import sys
+if sys.version_info < (3,10):
+    TypeAlias = object
+else:
+    from typing import TypeAlias
+LiteralValue: TypeAlias = list[LiteralValue]|object
+'''
+        self.checkChains(
+                code, 
+                ['sys -> (sys -> (.version_info -> (<Compare> -> ())))',
+                 'TypeAlias -> (TypeAlias -> ())', 
+                 'TypeAlias -> (TypeAlias -> ())',
+                 'LiteralValue -> (LiteralValue -> (<Subscript> -> (<BinOp> -> ())))',
+                 ],
+                filename='test.pyi',
+            )
+
     def test_stubs_class_decorators(self):
         code = '''
 @dataclass_transform