-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate documentation #120
base: master
Are you sure you want to change the base?
Generate documentation #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be replaced by a readthedocs.yml file at the root of the repository to publish the docs with readthedocs: https://pydoctor.readthedocs.io/en/latest/publish-readthedocs.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'm more familiar with read the doc, plus I'd rather have the doc linked to the project name and not my github handle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good I’ll do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serge-sans-paille I've added the .readthedocs.yalm file. Tell me when you finalize the integration with ReadThedocs. Don't forget to enable to builds on Pull requests. Then I'll add a commit to the branch and we'll see if it works.
@@ -1,3 +1,8 @@ | |||
from __future__ import absolute_import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this legacy import as a drive-by change
UseDefChains, | ||
Def, ) | ||
|
||
__all__ = ['Ancestors', 'DefUseChains', 'UseDefChains', 'Def', '__version__'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary such that public objects are documented in the top-level module and not where they are implemented
@@ -1,3 +1,8 @@ | |||
from __future__ import absolute_import | |||
".. include:: README.rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of the readme will be duplicated on the generated website. Maybe it's best to keep it simple and write a couple of lines instead?
PRIVATE:beniget.beniget | ||
PRIVATE:beniget.ordered_set | ||
PRIVATE:beniget.version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hides all submodules by default, but they can be shown by clicking on "Show Private" button at the top of each page.
commands=pytest --doctest-modules {posargs:beniget/ tests/} | ||
[testenv:docs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tox environment is only used for local development.
.github/workflows/docs.yml
Outdated
--project-url=https://github.com/$GITHUB_REPOSITORY \ | ||
--html-viewsource-base=https://github.com/$GITHUB_REPOSITORY/tree/$GITHUB_SHA \ | ||
--html-base-url=https://$GITHUB_REPOSITORY_OWNER.github.io/${GITHUB_REPOSITORY#*/} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other non-dynamic options are given by the config file.
It looks like this: https://tristanlatr.github.io/beniget/