Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate documentation #120

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tristanlatr
Copy link
Contributor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced by a readthedocs.yml file at the root of the repository to publish the docs with readthedocs: https://pydoctor.readthedocs.io/en/latest/publish-readthedocs.html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm more familiar with read the doc, plus I'd rather have the doc linked to the project name and not my github handle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good I’ll do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serge-sans-paille I've added the .readthedocs.yalm file. Tell me when you finalize the integration with ReadThedocs. Don't forget to enable to builds on Pull requests. Then I'll add a commit to the branch and we'll see if it works.

@@ -1,3 +1,8 @@
from __future__ import absolute_import
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this legacy import as a drive-by change

UseDefChains,
Def, )

__all__ = ['Ancestors', 'DefUseChains', 'UseDefChains', 'Def', '__version__']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary such that public objects are documented in the top-level module and not where they are implemented

@@ -1,3 +1,8 @@
from __future__ import absolute_import
".. include:: README.rst"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the readme will be duplicated on the generated website. Maybe it's best to keep it simple and write a couple of lines instead?

Comment on lines +7 to +9
PRIVATE:beniget.beniget
PRIVATE:beniget.ordered_set
PRIVATE:beniget.version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides all submodules by default, but they can be shown by clicking on "Show Private" button at the top of each page.

commands=pytest --doctest-modules {posargs:beniget/ tests/}
[testenv:docs]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tox environment is only used for local development.

Comment on lines 36 to 38
--project-url=https://github.com/$GITHUB_REPOSITORY \
--html-viewsource-base=https://github.com/$GITHUB_REPOSITORY/tree/$GITHUB_SHA \
--html-base-url=https://$GITHUB_REPOSITORY_OWNER.github.io/${GITHUB_REPOSITORY#*/} \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other non-dynamic options are given by the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants