Improve support for imports #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlatr
commented
Feb 13, 2025
|
The support for imports could be useful for QuantStack/memestra#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives beniget understanding of imports, including relative imports.
Relative imports will be parsed as expected only if beniget is given the module name explicitly when calling
DefUseChains(modname="stuff.bar"). If the analyzed module is the__init__.pyfile of a packages, the argumentis_package=Trueshould also be passed to have correct understanding of relative imports.This version keeps it simple by not trying to deduce the module name from the filename.