Docs: Update README.md for React-Router 7 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import {isbot} from "isbot"; | ||
| import type {RenderToPipeableStreamOptions} from "react-dom/server"; | ||
| import {renderToPipeableStream} from "react-dom/server"; | ||
| import {createInstance} from "i18next"; | ||
| import i18next from "./i18next.server"; |
There was a problem hiding this comment.
typo, you are actually referencing it as i18nextServer below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey sergio,
Thanks for the library! While setting it up for RR7, I noticed some changes that are not yet present in the README, so I added them here.
A couple things that were not clear to me though:
Does it affect the behavior of the app in any way, if the i18next instance is created in the returned Promise of
handleRequestinentry.server.tsxcompared to making that function async and creating the instance outside of the promise? As far as I know, it does not - feel free to correct me here.Is the
window.requestIdelCallbackcheck still needed? The RR team removed it from the officialentry.server.tsxfile.