Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fixes #25

Closed
wants to merge 257 commits into from
Closed

typo fixes #25

wants to merge 257 commits into from

Conversation

zezinho42
Copy link

No description provided.

@zezinho42
Copy link
Author

Thanks for including the other PR. This one was only portuguese fixes to fix in screen

@rzr
Copy link

rzr commented Dec 3, 2019

Feel free to forward upstream:
https://github.com/rzr/pinball

@zezinho42
Copy link
Author

Feel free to forward upstream:
https://github.com/rzr/pinball

Sorry I feel lost. What upstream? It does not even have the translation files! It had no commit for years, will it really be the new upstream?

@sergiomb2
Copy link
Owner

rzr doesn't give me commit access , because i don't do a thing that I don't know how to do but accept yours pull requests

@rzr
Copy link

rzr commented Dec 4, 2019

I will merge PR in https://github.com/rzr/pinball and then push to https://sf.net/p/pinball/

I will also investigate for a solution to manage tables ouside tree.
adoptware#4

Do you want to join ours forces ?

@zezinho42
Copy link
Author

I will merge PR in https://github.com/rzr/pinball and then push to https://sf.net/p/pinball/

Thanks, good news!

I will also investigate for a solution to manage tables ouside tree.
rzr#4

Ok.

Do you want to join ours forces ?

I do, but I am not a programmer. Still, I'd like to help. For now, I have translated, and tried to fix silly bugs like the screen size limit. Please tell me if you see how I can help?

@rzr
Copy link

rzr commented Jul 4, 2022

I plan to release a version of upstream (based on sdl2) is there anything you would like to forward there ?

@sergiomb2
Copy link
Owner

sergiomb2 commented Jul 4, 2022

over your master (https://github.com/adoptware/pinball/tree/master) I added a few patches , https://github.com/sergiomb2/pinball/tree/latest but is not finished ,
I readd the tables just to be able to apply my patches , BTW where are the tables ?

I had more than 60 patches to review, I think I have 20, yet, to review including more translations CA and ES

@rzr
Copy link

rzr commented Jul 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants