Skip to content

Conversation

@smolo-de
Copy link

~bugfix for tenant regex validation
+add testcases
+add method to set defaultrequestheaders

+add method to set defaultrequestheader
+add testcases
@mishamyte
Copy link
Member

Hey @smolo-de,

Thank you a lot for the contribution.

Have 2 more questions:

  1. Pls check the comment to test
  2. I'm curious what is your use-case for new method, related to default headers?

@smolo-de
Copy link
Author

Hey @smolo-de,

Thank you a lot for the contribution.

Have 2 more questions:

  1. Pls check the comment to test
  2. I'm curious what is your use-case for new method, related to default headers?

Regarding the first point, I will take another look at it and correct it.

The new function is intended to serve as a backup and supplement in case further header information is required. For example, there is also “X-Loki-Actor-Path,” which is not currently implemented. If someone needs the option to override the headers, they could do so themselves in an emergency!

@mishamyte
Copy link
Member

@smolo-de sorry for the delay. It looks like pipelines are failing due to violating StyleCop rules. Can you pls have a look, so we can merge it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants