Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support writing to new Notepad on Windows 11 #60

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Updates to support writing to new Notepad on Windows 11 #60

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1728be2
Implementing an alternate way of finding editor handle for new Notepad
bstordrup May 11, 2023
65f5399
Changes to handle changes in Notepad that allows multiple documents.
bstordrup May 12, 2023
0084257
In some situations, a notepad window opened after logging start would…
bstordrup May 12, 2023
ab9ac54
Sometimes, the editor handle seems not correct. So if the text length…
bstordrup May 15, 2023
1b5bec4
Implementing an alternate way of finding editor handle for new Notepad
bstordrup May 11, 2023
7647b4b
Changes to handle changes in Notepad that allows multiple documents.
bstordrup May 12, 2023
756b269
In some situations, a notepad window opened after logging start would…
bstordrup May 12, 2023
7802dec
Sometimes, the editor handle seems not correct. So if the text length…
bstordrup May 15, 2023
7fdcf57
Merge branch 'Issue59_FindEditorHandleThroughChildWindowEnumeration' …
bstordrup May 30, 2023
6db95e1
Implementing an alternate way of finding editor handle for new Notepad
bstordrup May 11, 2023
7ab2698
PR rebase & minor tweaks
augustoproiete Jun 4, 2023
c28d1f3
Add retry policy (3 attempts before giving up)
augustoproiete Jun 4, 2023
3b920cc
Resynced
bstordrup Jun 6, 2023
e86d7d3
Rewriting logic to avoid Goto statement. The buffer is retrieved usin…
bstordrup Jun 6, 2023
c733e95
Setting succeeded after trying to write.
bstordrup Jun 6, 2023
25a4a03
Change as per suggestion
bstordrup Jun 7, 2023
5d43c96
Merge from master
bstordrup Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Serilog.Sinks.Notepad/Sinks/Notepad/Interop/NotepadTextWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,11 @@ public override void Flush()
// Get how many characters are in the Notepad editor after putting in new text
var textLengthAfter = User32.SendMessage(_currentNotepadEditorHandle, User32.WM_GETTEXTLENGTH, IntPtr.Zero, IntPtr.Zero);

// Determine if the write succeeded. This will break the loop.
succeeded = textLengthAfter != textLength;
bstordrup marked this conversation as resolved.
Show resolved Hide resolved

// If no change in the text length, reset editor handle to try to find it again.
if (textLengthAfter == textLength)
if (!succeeded)
{
_currentNotepadEditorHandle = IntPtr.Zero;
attempts++;
Expand Down