Add support for task category injection #59
Conversation
| @@ -55,7 +56,8 @@ public static LoggerConfiguration EventLog( | |||
| string outputTemplate = DefaultOutputTemplate, | |||
| IFormatProvider? formatProvider = null, | |||
| LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum, | |||
| IEventIdProvider? eventIdProvider = null) | |||
| IEventIdProvider? eventIdProvider = null, | |||
| ICategoryNumberProvider? categoryNumberProvider = null) | |||
There was a problem hiding this comment.
In the EventLog.WriteEvent API, the category is referred to as just category (rather than categoryNumber) - perhaps ICategoryProvider, or IEventLogCategoryProvider would be better?
There was a problem hiding this comment.
Renamed it to ICategoryProvider.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Folder Include="Properties\PublishProfiles\" /> |
There was a problem hiding this comment.
Nit, don't need to include this folder.
There was a problem hiding this comment.
You are right, deleted these entries again.
| : this(source, logName, textFormatter, machineName, manageEventSource, new EventIdHashProvider()) | ||
| { | ||
| } | ||
|
|
| { | ||
| if (source == null) throw new ArgumentNullException(nameof(source)); | ||
| if (textFormatter == null) throw new ArgumentNullException(nameof(textFormatter)); | ||
| if (eventIdProvider == null) throw new ArgumentNullException(nameof(eventIdProvider)); | ||
| if (eventIdProvider == null) |
There was a problem hiding this comment.
Instead of reassigning the parameters, it might be clearer to just use null coalescing for the assignments below -
_eventIdProvider = eventIdProvider ?? new EventIdHashProvider();There was a problem hiding this comment.
Good point - replaced with null coalescing
| /// </summary> | ||
| sealed class NullCategoryNumberProvider : ICategoryNumberProvider | ||
| { | ||
|
|
There was a problem hiding this comment.
Removed the extra white space
| @@ -0,0 +1,31 @@ | |||
| // Copyright 2016 Serilog Contributors | |||
There was a problem hiding this comment.
Updated to 2025 on all new files in this PR
This allows for the injection of task category numbers. You can see these numbers afterwards in the ¨Task Category¨ column within the event viewer.