[#39] String interpolation in coffer output messages
#63
Conversation
app/Main.hs
Outdated
| let entryTo = getEntryFromCreateError err | ||
| let header = "'" +| from |+ "' to '" +| entryTo ^. path |+ "':" | ||
| let header = [int|s|'#{from}' to '#{entryTo ^. path}':|] | ||
| let errorMsg = createErrorToBuilder err | ||
| pure $ unlinesF @_ @Builder $ header : [indentF 2 errorMsg] |
There was a problem hiding this comment.
I didn't test it, but would this work?
let entryTo = getEntryFromCreateError err
pure [int||
'#{from}' to '#{entryTo ^. path}':
#{createErrorToBuilder err}
|]There was a problem hiding this comment.
Actually, also just noticed that buildErrorMessages doesn't have to return Sem r [Builder], it could just return a [Builder].
There was a problem hiding this comment.
Oh, I'm afraid no. Just a couple of days ago I witnessed the need for such functionality too, so let the ticket be serokell/nyan-interpolation#11.
There was a problem hiding this comment.
Ah right, and one of the messages returned by createErrorToBuilder does have multiple lines :/
Ok, let's leave it like this for now. @DK318, please create a separate issue to improve this when serokell/nyan-interpolation#11 is done + released.
There was a problem hiding this comment.
Note: while we're here, we could still change Sem r [Builder] -> [Builder] in this PR.
There was a problem hiding this comment.
@DK318 I checked, Sem r [Builder] can be changed to [Builder] (as mentioned above). For example, like this:
buildErrorMessages = fmap \(from, err) ->
let entryPath = getEntryFromCreateError err
header = [int|s|'#{from}' to '#{entryTo ^. path}':|]
errorMsg = createErrorToBuilder err
in unlinesF @_ @Builder $ header : [indentF 2 errorMsg]
app/Main.hs
Outdated
| let entryTo = getEntryFromCreateError err | ||
| let header = "'" +| from |+ "' to '" +| entryTo ^. path |+ "':" | ||
| let header = [int|s|'#{from}' to '#{entryTo ^. path}':|] | ||
| let errorMsg = createErrorToBuilder err | ||
| pure $ unlinesF @_ @Builder $ header : [indentF 2 errorMsg] |
There was a problem hiding this comment.
@DK318 I checked, Sem r [Builder] can be changed to [Builder] (as mentioned above). For example, like this:
buildErrorMessages = fmap \(from, err) ->
let entryPath = getEntryFromCreateError err
header = [int|s|'#{from}' to '#{entryTo ^. path}':|]
errorMsg = createErrorToBuilder err
in unlinesF @_ @Builder $ header : [indentF 2 errorMsg]
|
Oh, this PR is really outdated. Still waiting for a review 😄 |
Looks like you have 2 reviews now, I really only had that 1 small comment ^^ |
|
Oh. This |
DK318
force-pushed
the
dk318/#39-strings-interpolation
branch
from
5432993
to
ce9d09a
Compare
Problem: at this moment constructing some messages in `Main.hs` looks very convoluted (e.g. message in `set-field` command). Solution: used `nyan-interpolation` package in `Main.hs`.
DK318
force-pushed
the
dk318/#39-strings-interpolation
branch
from
f9505cf
to
0608ae9
Compare
Description
Problem
At this moment constructing some messages in
Main.hslooks very convoluted (e.g. message in
set-fieldcommand).Solution
Used
nyan-interpolationpackage inMain.hs.Related issue(s)
nyan-interpolation#39✅ Checklist for your Pull Request
Related changes (conditional)
silently reappearing again.
of Public Contracts policy.
and
Stylistic guide (mandatory)