[Chore] Make activation wait timeout configurable #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilTaken
reviewed
Nov 1, 2023
PhilTaken
approved these changes
Nov 2, 2023
Problem: Currently profile activation waiting timeout is hardcoded to 240 seconds, see #48. In some cases, this timeout can be exceeded (e.g. activation performs a heavy DB migration and waits for it to finish before considering the profile activation succesful). Solution: Make this timeout configurable via 'activationTimeout' deploy attribute or corresponding '--activation-timeout' CLI option. For the sake of backward compatibility, the new 'wait' subcommand '--activation-timeout' option is made optional and defaults to 240 seconds if it wasn't provided.
rvem
force-pushed
the
rvem/make-wait-activation-timeout-configurable
branch
from
2e259eb
to
50d640f
Compare
delete-merged-branch
bot
deleted the
rvem/make-wait-activation-timeout-configurable
branch
|
Hey @PhilTaken |
|
Hey, @SufyanDahalan. Thanks for catching the lack of documentation, we'll update it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Currently profile activation waiting timeout is hardcoded to 240 seconds, see #48. In some cases, this timeout can be exceeded (e.g.
activation performs a heavy DB migration and waits for it to finish before considering the profile activation succesful).
Solution: Make this timeout configurable via 'activationTimeout' deploy attribute or corresponding '--activation-timeout' CLI option. For the sake of backward compatibility, the 'wait' subcommand new '--activation-timeout' option is made optional and defaults to 240 seconds if it wasn't provided.