Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update CI #33

Merged
merged 3 commits into from
Jul 9, 2024
Merged

[Chore] Update CI #33

merged 3 commits into from
Jul 9, 2024

Conversation

gromakovsky
Copy link
Member

@gromakovsky gromakovsky commented Jul 8, 2024

Problem: we've recently supported ghc-9.10.1, but it's not tested by CI. Also we're still testing ghc-8.8.4, which is rather old and causes some troubles when updating Nix dependencies.

Solution: add 9.10.1 to tested GHC versions, remove 8.8.4.

Problem2: CI is triggered only on push, so it won't work in case of PRs from forks.
Solution: trigger it on PRs as well.

gromakovsky and others added 2 commits July 8, 2024 13:50
Problem: we've recently supported ghc-9.10.1, but it's not tested
by CI. Also we're still testing ghc-8.8.4, which is rather old and
causes some troubles when updating Nix dependencies.

Solution: add 9.10.1 to tested GHC versions, remove 8.8.4.
hackage     a62dac66a9 (2024-05-13) -> 5153fdaef0 (2024-07-08)
haskell-nix 28fceff2ef (2024-01-10) -> 34946405e8 (2024-06-21)
nixpkgs     sha256-dd/ (1970-01-01) -> fe065f84d7 (2024-07-01)
stackage    207b7104d5 (2024-05-12) -> c84e07a4e0 (2024-07-06)
@gromakovsky gromakovsky changed the title [Chore] Update GHC versions tested by CI [Chore] Update CI Jul 8, 2024
Problem: CI is triggered only on push, so it won't work in case of
PRs from forks.
Solution: trigger it on PRs as well. Trigger on push only when the
branch is master.
If you want to run on push to your feature branch, you can edit
check.yml in your branch.
@gromakovsky gromakovsky merged commit a8eb95d into master Jul 9, 2024
9 checks passed
@gromakovsky gromakovsky deleted the gromak/ci-updates branch July 10, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants