Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] Add lenses for config-related types #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nalkuatov
Copy link

Adds lenses for config-related types as well as common lenses
operators & types.

This exists as an alternative to #17 - we can stick to this solution if it looks less verbose.

some Lens operators like (?=) or (%=) are yet to be added and the tests are yet to be written

Description

Related issue(s)

Resolves #15

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

Problem: It's quite inconvenient to access config-related records'
fields by hand, especially when it comes to nested ones.

Solution: Add lenses for config-related types and add common lenses
operators & types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lenses for config
1 participant