[#591] Remove unnecessary tezos-client deps #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
6 times, most recently
from
7a8eabf to
b29f9cd
Compare
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
5 times, most recently
from
0e00525 to
2231052
Compare
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
9 times, most recently
from
779aaea to
10ad464
Compare
|
Seems that only binary that requires fixing is tezos-client. |
|
@rvem can you approve that check is done correctly, and if so, I will remove all unnecessary for this issue changes? |
|
rvem
reviewed
Aug 16, 2023
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
2 times, most recently
from
6cd637f to
9fa01a6
Compare
rvem
reviewed
Aug 22, 2023
scripts/print-bottles-deps.py
Outdated
| import sys | ||
|
|
||
| binaries = [ | ||
| "tezos-client", |
There was a problem hiding this comment.
v18.0-rc1 introduced new *-dac binaries with the corresponding formulae. Could you please check them as well?
There was a problem hiding this comment.
Sure, I will as soon as v18.0 is published
There was a problem hiding this comment.
v18.0-rc1 and corresponding formulae are already published, btw
There was a problem hiding this comment.
Seems that dac files also have libffi dependency which they actually do not use. I will remove the dependency now. Do you want to check anything else here, @rvem
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
2 times, most recently
from
d710e0f to
80a410f
Compare
|
|
rvem
approved these changes
Sep 6, 2023
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
from
68c9c71 to
224e804
Compare
Problem: Many tezos binaries have a libffi dependency which it actually does not use. It needs to be removed Solution: Removed unnecessary dependencies, check that bottles build without it
PruStephan
force-pushed
the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
from
224e804 to
effcf5e
Compare
PruStephan
deleted the
PruStephan/Remove_unnecessary_tezos_client_deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR removes unnecessary dependency of
libffifrom tezos-client build. This seems to be the only dependency that is unnecessary, as without others brew fails to build it.Related issue(s)
Closes: #591
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)