[Chore] Utilize OCTEZ_EXECUTABLES env var #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krendelhoff2
force-pushed
the
krendelhoff/chore-use-octez-executables
branch
4 times, most recently
from
b532720 to
501090e
Compare
pasqu4le
approved these changes
Sep 11, 2023
| @@ -19,7 +19,7 @@ Static binaries building using custom alpine image. | |||
| image defined in [Dockerfile](build/Dockerfile). In order to build them you should specify | |||
| `OCTEZ_VERSION` env variable and run the script: | |||
| ``` | |||
| export OCTEZ_VERSION="v14.1" | |||
| export OCTEZ_VERSION="v17.3" | |||
There was a problem hiding this comment.
These are meant to be example commands and we don't update them for every Octez update, so I think they are fine either way.
TBH I find this commit unnecessary, but I don't mind it either, so feel free to keep it
Problem: `make static` command utilizes `OCTEZ_EXECUTABLES` variable, which we can use to specify exact binaries to build. Also, it could be used to build experimental or development binaries. Solution: Let user provide `OCTEZ_EXECUTABLES` env var and pass it to the build.
Problem: `OCTEZ_VERSION` in docs is too outdated. Solution: Update it.
krendelhoff2
force-pushed
the
krendelhoff/chore-use-octez-executables
branch
from
501090e to
367a6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
make staticcommand utilizesOCTEZ_EXECUTABLESvariable,which we can use to specify exact binaries to build. Also, it
could be used to build experimental or development binaries.
Solution: Let user provide
OCTEZ_EXECUTABLESenv var and passit to the build.
Related issue(s)
Resolves #
Related changes (conditional)
I checked whether I should update the README
I checked whether native packaging works, i.e. native binary packages
can be successfully built.
Stylistic guide (mandatory)